Alon Bar-Lev has posted comments on this change. Change subject: vdsClient: alternative ways to provide password ...................................................................... Patch Set 15: Code-Review+1 (1 comment) thanks! http://gerrit.ovirt.org/#/c/24733/15/client/vdsClient.py File client/vdsClient.py: Line 418: for arg in args[3:]: Line 419: if arg in ['disconnect', 'keep', 'fail']: Line 420: connAct = arg Line 421: elif arg.startswith('param='): Line 422: params = self._parseDriveSpec(args[4]) I do not understand why we cannot put param= and auth= at same option list, but I trust there is a reason... Line 423: else: Line 424: extra_args = parseArgs(arg) Line 425: if 'auth' in extra_args: Line 426: auth_password = getPassword(extra_args['auth']) -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt; Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt; Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt; Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com&gt; Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt; Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt; Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt; Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes