Change in vdsm[master]: Introduce getMountPoint for NfsStorageDomain

List overview All Threads
Download

newer

older

Change in vdsm[master]: Unify...

Change in vdsm[master]: Fix...

deepakcs＠linux.vnet.ibm.com

20 Sep 2012 20 Sep '12

5:26 a.m.

Deepak C Shetty has uploaded a new change for review.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Introduce getMountPoint for NfsStorageDomain

Move the code to generate the mount point into a seperate function, so that classes reusing NfsStorageDomain can override the function to present their own mount point path.

Change-Id: I80f98eddcc31c1f01f42af838ecc483abb955f41 Signed-off-by: Deepak C Shetty deepakcs@linux.vnet.ibm.com --- M vdsm/storage/nfsSD.py 1 file changed, 6 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/8085/1

diff --git a/vdsm/storage/nfsSD.py b/vdsm/storage/nfsSD.py index d84fee6..6b53208 100644 --- a/vdsm/storage/nfsSD.py +++ b/vdsm/storage/nfsSD.py @@ -71,8 +71,7 @@ # Create local path mntPath = fileUtils.transformPath(remotePath)

- mntPoint = os.path.join(cls.storage_repository, - sd.DOMAIN_MNT_POINT, mntPath) + mntPoint = cls.getMountPoint(mntPath)

cls._preCreateValidation(sdUUID, mntPoint, remotePath, version)

@@ -94,6 +93,11 @@

return fsd

+ @classmethod + def getMountPoint(cls, mountPath): + return os.path.join(cls.storage_repository, + sd.DOMAIN_MNT_POINT, mountPath) + def selftest(self): """ Run internal self test

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: I80f98eddcc31c1f01f42af838ecc483abb955f41 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com

Show replies by date

deepakcs＠linux.vnet.ibm.com

20 Sep 20 Sep

5:28 a.m.

Deepak C Shetty has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 1:

@Dan, As requested by you, i have split this change (from 6856) into a separate patch.

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I80f98eddcc31c1f01f42af838ecc483abb955f41 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com

deepakcs＠linux.vnet.ibm.com

5:28 a.m.

Deepak C Shetty has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 1: Verified

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

11:28 a.m.

Dan Kenigsberg has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 1: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

deepakcs＠linux.vnet.ibm.com

26 Sep 26 Sep

7:04 a.m.

Deepak C Shetty has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 2: Verified

Not sure, why patchset 2 is seen, tho' i never sent a 2nd patch. Looking closely, its exactly the same as patch set 1 !

I already have got a +1 for my patchset 1, putting it here for others to know.

Also setting +1 verified for 2nd patchset.

thanx, deepak

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I80f98eddcc31c1f01f42af838ecc483abb955f41 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com

Ryan Harper

8:01 a.m.

Ryan Harper has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 2:

I've been told that when you update a patch that depends on one, the dependent patch get's updated. This is a gerrit bug. Unfortunately, we have to re-review the new patch.

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Ryan Harper

8:01 a.m.

Ryan Harper has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 2: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

deepakcs＠linux.vnet.ibm.com

10:30 p.m.

Deepak C Shetty has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 2: No score

@Ryan, Thanks for the info & the review. Cheers, deepak

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

deepakcs＠linux.vnet.ibm.com

4 Oct 4 Oct

4:36 a.m.

Deepak C Shetty has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 2: Verified

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

deepakcs＠linux.vnet.ibm.com

5 Oct 5 Oct

6:06 a.m.

Deepak C Shetty has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 3: Verified

Submitted as part of a new topic

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I80f98eddcc31c1f01f42af838ecc483abb955f41 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com

agl＠us.ibm.com

17 Oct 17 Oct

9:51 a.m.

Adam Litke has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 3: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I80f98eddcc31c1f01f42af838ecc483abb955f41 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com

Jenkins CI RO

18 Dec 18 Dec

4:30 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/399/ (1/2)

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I80f98eddcc31c1f01f42af838ecc483abb955f41 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

4:32 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/434/ (2/2)

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

deepakcs＠linux.vnet.ibm.com

4:33 a.m.

Deepak C Shetty has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 4: Verified

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:35 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 4: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/399/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/434/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4 Jan 4 Jan

7:11 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/598/ (1/2)

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I80f98eddcc31c1f01f42af838ecc483abb955f41 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

deepakcs＠linux.vnet.ibm.com

7:14 a.m.

Deepak C Shetty has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 5: Verified

fixed issues reported by jenkins

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7:14 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/563/ (2/2)

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7:15 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 5:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/563/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/598/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Federico Simoncelli

8 Jan 8 Jan

12:35 a.m.

Federico Simoncelli has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 5: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

abaron＠redhat.com

10 Jan 10 Jan

2:16 p.m.

Ayal Baron has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 5: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I80f98eddcc31c1f01f42af838ecc483abb955f41 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

11 Jan 11 Jan

10:34 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/687/ (1/2)

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I80f98eddcc31c1f01f42af838ecc483abb955f41 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

10:34 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/652/ (2/2)

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:36 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 6:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/652/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/687/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

deepakcs＠linux.vnet.ibm.com

10:37 a.m.

Deepak C Shetty has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 6: Verified

Had got approval from Ayal for prev patchset It had merge conflict, hence rebased and reposted new patchset

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

12 Jan 12 Jan

11:50 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Patch Set 6: Looks good to me, approved

Copying score

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

11:50 p.m.

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Introduce getMountPoint for NfsStorageDomain ......................................................................

Introduce getMountPoint for NfsStorageDomain

Move the code to generate the mount point into a seperate function, so that classes reusing NfsStorageDomain can override the function to present their own mount point path.

Change-Id: I80f98eddcc31c1f01f42af838ecc483abb955f41 Signed-off-by: Deepak C Shetty deepakcs@linux.vnet.ibm.com --- M vdsm/storage/nfsSD.py 1 file changed, 6 insertions(+), 2 deletions(-)

Approvals: Dan Kenigsberg: Looks good to me, approved Deepak C Shetty: Verified

-- To view, visit http://gerrit.ovirt.org/8085 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: I80f98eddcc31c1f01f42af838ecc483abb955f41 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

4186

Age (days ago)

4301

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

26 comments

7 participants

tags (0)

participants (7)

abaron＠redhat.com
agl＠us.ibm.com
Dan Kenigsberg
deepakcs＠linux.vnet.ibm.com
Federico Simoncelli
Jenkins CI RO
Ryan Harper