Royce Lv has uploaded a new change for review.
Change subject: schema: nit schema fix ......................................................................
schema: nit schema fix
Change-Id: Ic24083ece5facab57a6f2f71aa150a8b02e82b0f Signed-off-by: Royce Lvlvroyce@linux.vnet.ibm.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/9150/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json index d210c7d..4c5997d 100644 --- a/vdsm_api/vdsmapi-schema.json +++ b/vdsm_api/vdsmapi-schema.json @@ -176,7 +176,7 @@ {'type': 'SetupNetworkNetAttributes', 'data': {'*vlan': 'str', '*bonding': 'str', '*nic': ['str'], '*ipaddr': 'str', '*netmask': 'str', '*gateway': 'str', '*bootproto': 'str', - '*delay': 'uint', '*onboot': 'bool', 'remove': 'bool'}} + '*delay': 'uint', '*onboot': 'bool', '*remove': 'bool'}}
## # @SetupNetworkBondAttributes:
-- To view, visit http://gerrit.ovirt.org/9150 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ic24083ece5facab57a6f2f71aa150a8b02e82b0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com
Adam Litke has posted comments on this change.
Change subject: schema: nit schema fix ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
Yep. Not only does the documentation string agree with this change, but the code itself states that it is optional.
-- To view, visit http://gerrit.ovirt.org/9150 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic24083ece5facab57a6f2f71aa150a8b02e82b0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: schema: nit schema fix ......................................................................
schema: nit schema fix
Change-Id: Ic24083ece5facab57a6f2f71aa150a8b02e82b0f Signed-off-by: Royce Lvlvroyce@linux.vnet.ibm.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Adam Litke: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/9150 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ic24083ece5facab57a6f2f71aa150a8b02e82b0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: schema: nit schema fix ......................................................................
Patch Set 1: Verified; Looks good to me, approved
Thanks.
-- To view, visit http://gerrit.ovirt.org/9150 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic24083ece5facab57a6f2f71aa150a8b02e82b0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
vdsm-patches@lists.fedorahosted.org