Change in vdsm[master]: Rename parent volume in blockSD.getAllVolumes.

List overview All Threads
Download

newer

older

Change in vdsm[master]: Probe cpu...

Change in vdsm[ovirt-3.2]: Check...

ewarszaw＠redhat.com

16 Oct 2012 16 Oct '12

3:30 p.m.

Eduardo has uploaded a new change for review.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Rename parent volume in blockSD.getAllVolumes.

Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339 Signed-off-by: Eduardo ewarszaw@redhat.com --- M vdsm/storage/blockSD.py 1 file changed, 5 insertions(+), 5 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/8608/1

diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index e596fb6..d8f7824 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -159,14 +159,14 @@ for vName in vols.iterkeys(): res[vName] = {'imgs': [], 'parent': None}

- for vName, vImg, vPar in vols.itervalues(): - res[vName]['parent'] = vPar + for vName, vImg, parentVol in vols.itervalues(): + res[vName]['parent'] = parentVol if vImg not in res[vName]['imgs']: res[vName]['imgs'].insert(0, vImg) - if vPar != sd.BLANK_UUID and \ + if parentVol != sd.BLANK_UUID and \ not vName.startswith(blockVolume.image.REMOVED_IMAGE_PREFIX) \ - and vImg not in res[vPar]['imgs']: - res[vPar]['imgs'].append(vImg) + and vImg not in res[parentVol]['imgs']: + res[parentVol]['imgs'].append(vImg)

return dict((k, sd.ImgsPar(tuple(v['imgs']), v['parent'])) for k, v in res.iteritems())

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com

Show replies by date

ewarszaw＠redhat.com

16 Oct 16 Oct

3:35 p.m.

Eduardo has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 1:

Requested in: http://gerrit.ovirt.org/#/c/8506/

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com

shuming＠linux.vnet.ibm.com

3:56 p.m.

Shu Ming has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 2: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com

abaron＠redhat.com

22 Oct 22 Oct

8:26 a.m.

Ayal Baron has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 2: (2 inline comments)

The patch is fine, but for bookkeeping need to explain why you're doing this in the commit message.

.................................................... Commit Message Line 3: AuthorDate: 2012-10-16 17:28:06 +0200 Line 4: Commit: Eduardo Warszawski ewarszaw@redhat.com Line 5: CommitDate: 2012-10-16 17:37:25 +0200 Line 6: Line 7: Rename parent volume in blockSD.getAllVolumes. why? Line 8: Line 9: Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339

Line 5: CommitDate: 2012-10-16 17:37:25 +0200 Line 6: Line 7: Rename parent volume in blockSD.getAllVolumes. Line 8: Line 9: Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339 related to?

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com

Jenkins CI RO

9 Dec 9 Dec

5:52 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/260/ (1/2)

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

5:52 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/294/ (2/2)

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:56 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 3: I would prefer that you didn't submit this

Build Unstable

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/260/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/294/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

abaron＠redhat.com

28 Jan 28 Jan

10:34 p.m.

Ayal Baron has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 3: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

6 Feb 6 Feb

8:17 a.m.

Dan Kenigsberg has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 3:

no semantic change in patch.

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

3:20 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1202/ (2/3)

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

3:20 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/313/ (3/3)

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3:20 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1167/ (1/3)

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3:26 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 4: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1167/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1202/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/313/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

abaron＠redhat.com

9:39 p.m.

Ayal Baron has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 4: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7 Feb 7 Feb

10:49 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1172/ (2/3)

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

10:49 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1207/ (3/3)

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:49 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/318/ (1/3)

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

10:59 a.m.

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Rename parent volume in blockSD.getAllVolumes.

Renaming variable names for better readability.

Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339 Signed-off-by: Eduardo ewarszaw@redhat.com --- M vdsm/storage/blockSD.py 1 file changed, 11 insertions(+), 10 deletions(-)

Approvals: Dan Kenigsberg: Verified; Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: I62f1385e4af90a923c5d97a71571bea8780aa339 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

10:59 a.m.

Dan Kenigsberg has posted comments on this change.

Change subject: Rename parent volume in blockSD.getAllVolumes. ......................................................................

Patch Set 5: Verified; Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/8608 To unsubscribe, visit http://gerrit.ovirt.org/settings

4159

Age (days ago)

4273

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

18 comments

5 participants

tags (0)

participants (5)

abaron＠redhat.com
Dan Kenigsberg
ewarszaw＠redhat.com
Jenkins CI RO
shuming＠linux.vnet.ibm.com