Zhou Zheng Sheng has uploaded a new change for review.
Change subject: PEP 8: fix "E302 expected 2 blank lines" in tests/apiTests.py ......................................................................
PEP 8: fix "E302 expected 2 blank lines" in tests/apiTests.py
On my pep8 version 1.3.3, it reports error on this file and fails the build. The patch fixes this.
Change-Id: I27608d7d00c7d8e72a043eba387cd4e9f03fa837 Signed-off-by: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com --- M tests/apiTests.py 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/9346/1
diff --git a/tests/apiTests.py b/tests/apiTests.py index 4b1a56b..ff0a785 100644 --- a/tests/apiTests.py +++ b/tests/apiTests.py @@ -156,6 +156,7 @@ raise server.start()
+ class APITest(TestCaseBase): def expectAPI(self, obj, meth, retval): global _fakeret
-- To view, visit http://gerrit.ovirt.org/9346 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I27608d7d00c7d8e72a043eba387cd4e9f03fa837 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: PEP 8: fix "E302 expected 2 blank lines" in tests/apiTests.py ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/80/ (1/2)
-- To view, visit http://gerrit.ovirt.org/9346 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I27608d7d00c7d8e72a043eba387cd4e9f03fa837 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: PEP 8: fix "E302 expected 2 blank lines" in tests/apiTests.py ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/57/ (2/2)
-- To view, visit http://gerrit.ovirt.org/9346 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I27608d7d00c7d8e72a043eba387cd4e9f03fa837 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: PEP 8: fix "E302 expected 2 blank lines" in tests/apiTests.py ......................................................................
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/80/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/57/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/9346 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I27608d7d00c7d8e72a043eba387cd4e9f03fa837 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Zhou Zheng Sheng has posted comments on this change.
Change subject: PEP 8: fix "E302 expected 2 blank lines" in tests/apiTests.py ......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve
Pass autobuild.sh on my machine.
Jenkins unit test failure is not related to this patch. You can see from its console output at http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/80/console . Jenkins checkouts the commit 2c0fd0796ad to build which is origin/master, but not f97cbfe0aecf which is this patch. So it builds on the old code and triggers a PEP 8 violation that's exactly to be fixed in this patch.
-- To view, visit http://gerrit.ovirt.org/9346 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I27608d7d00c7d8e72a043eba387cd4e9f03fa837 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: PEP 8: fix "E302 expected 2 blank lines" in tests/apiTests.py ......................................................................
Patch Set 1: No score
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/94/ (2/2)
-- To view, visit http://gerrit.ovirt.org/9346 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I27608d7d00c7d8e72a043eba387cd4e9f03fa837 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: PEP 8: fix "E302 expected 2 blank lines" in tests/apiTests.py ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/57/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/94/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/9346 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I27608d7d00c7d8e72a043eba387cd4e9f03fa837 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: PEP 8: fix "E302 expected 2 blank lines" in tests/apiTests.py ......................................................................
Patch Set 1: Do not submit
Sorry, I've missed this change, and pushed my own version in http://gerrit.ovirt.org/9357
-- To view, visit http://gerrit.ovirt.org/9346 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I27608d7d00c7d8e72a043eba387cd4e9f03fa837 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Zhou Zheng Sheng has abandoned this change.
Change subject: PEP 8: fix "E302 expected 2 blank lines" in tests/apiTests.py ......................................................................
Patch Set 1: Abandoned
-- To view, visit http://gerrit.ovirt.org/9346 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I27608d7d00c7d8e72a043eba387cd4e9f03fa837 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org
-
Dan Kenigsberg -
Jenkins CI RO -
zhshzhou＠linux.vnet.ibm.com