Francesco Romani has uploaded a new change for review. Change subject: sampling: remove overcautious cpu count check ...................................................................... sampling: remove overcautious cpu count check It is very unlikely SC_NPROCESSORS_ONLN will ever be less than 1. The existing defensive code is more likely to hide a bug somewhere else. Change-Id: I0a732c0584f487f513b8445c227bccfaab9f92ab Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt; --- M vdsm/virt/sampling.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/47991/1 diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py index 91a8864..70ea2a4 100644 --- a/vdsm/virt/sampling.py +++ b/vdsm/virt/sampling.py @@ -247,7 +247,7 @@ super(HostSample, self).__init__() self.interfaces = _get_interfaces_and_samples() self.pidcpu = PidCpuSample(pid) - self.ncpus = max(os.sysconf('SC_NPROCESSORS_ONLN'), 1) + self.ncpus = os.sysconf('SC_NPROCESSORS_ONLN') self.totcpu = TotalCpuSample() meminfo = utils.readMemInfo() freeOrCached = (meminfo['MemFree'] + -- To view, visit https://gerrit.ovirt.org/47991 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0a732c0584f487f513b8445c227bccfaab9f92ab Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;