Dan Kenigsberg has posted comments on this change.
Change subject: Probe cpu count from new libvirt capabilities. ......................................................................
Patch Set 4: I would prefer that you didn't submit this
My main issue with this patch is that it is based on a libvirt feature missing from our both reference platforms.
If we take the code, wouldn't it cause getCaps to explode on el6?
-- To view, visit http://gerrit.ovirt.org/11709 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0e4a08cfcde6fb2e1ce4cf10478af72217c20ba5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org