Wenchao Xia has uploaded a new change for review.
Change subject: SUDO change, move fuser call to super vdsm ......................................................................
SUDO change, move fuser call to super vdsm
supervdsm.fuser() will return out result from executing, and fuser.py will parse it.
Change-Id: I0bb881e6bcad213db1d186e70f41b22d78ee3ecf Signed-off-by: wenchao xia xiawenc@linux.vnet.ibm.com --- M vdsm/storage/fuser.py M vdsm/supervdsmServer.py 2 files changed, 20 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/5314/1 -- To view, visit http://gerrit.ovirt.org/5314 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I0bb881e6bcad213db1d186e70f41b22d78ee3ecf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: SUDO change, move fuser call to super vdsm ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm/storage/fuser.py Line 18: # Refer to the README and COPYING files for full details of the license since this file has been written, we've grown older and smarter.
we should have a python encapsulation of fuser command line, see mount.py or gluster/cli.py for examples.
Then, you should expose some of that functionality from supervdsm.
.................................................... File vdsm/supervdsmServer.py Line 272: def fuser(self, path, mountPoint): for security, you should verify that path is something that is supposed to be vdsm-controlled.
-- To view, visit http://gerrit.ovirt.org/5314 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0bb881e6bcad213db1d186e70f41b22d78ee3ecf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: SUDO change, move fuser call to super vdsm ......................................................................
Patch Set 1: I would prefer that you didn't submit this
What Dan said
-- To view, visit http://gerrit.ovirt.org/5314 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0bb881e6bcad213db1d186e70f41b22d78ee3ecf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: SUDO change, move fuser call to super vdsm ......................................................................
Patch Set 1: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/199/
-- To view, visit http://gerrit.ovirt.org/5314 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0bb881e6bcad213db1d186e70f41b22d78ee3ecf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: SUDO change, move fuser call to super vdsm ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/199/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/5314 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0bb881e6bcad213db1d186e70f41b22d78ee3ecf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: SUDO change, move fuser call to super vdsm ......................................................................
Patch Set 1: Do not submit
I believe that this has been done already by http://gerrit.ovirt.org/13779
Thanks.
-- To view, visit http://gerrit.ovirt.org/5314 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0bb881e6bcad213db1d186e70f41b22d78ee3ecf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has abandoned this change.
Change subject: SUDO change, move fuser call to super vdsm ......................................................................
Patch Set 1: Abandoned
it's probably time to abandon this patch.
-- To view, visit http://gerrit.ovirt.org/5314 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I0bb881e6bcad213db1d186e70f41b22d78ee3ecf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org
-
Dan Kenigsberg -
Jenkins CI RO -
smizrahi＠redhat.com -
xiawenc＠linux.vnet.ibm.com