From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: containers: fetch image name from metadata
......................................................................
containers: fetch image name from metadata
In commit 46ba88dc557ee53adb8b3d20709a02a678910f6b
we started to remove smartness from the container domain parser.
The original plan was to get the image from the outside;
With the current plans to overhaul the domain metadata, it's
just simpler to add a new helper which parses it from the metadata.
This patch effectively restores part of the code removed in 46ba88dc55,
but now we call this explicitely, so we complete the removal
of unwanted and implicit smartness.
Change-Id: I78946d0ed8328d3196d8df1c461313258b5e25f0
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/containers/docker.py
M lib/vdsm/virt/containers/xmlfile.py
M tests/containers/data/full_dom.xml
M tests/containers/data/metadata_drive_map.xml
M tests/containers/data/minimal_dom.xml
M tests/containers/docker_test.py
6 files changed, 48 insertions(+), 31 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/74322
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78946d0ed8328d3196d8df1c461313258b5e25f0
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>