Hello Dan Kenigsberg, Francesco Romani, Michal Skrivanek,

I'd like you to do a code review. Please visit

http://gerrit.ovirt.org/27637

to review the following change.

Change subject: virt: Capture migration start time after the semaphore was accquired ......................................................................

virt: Capture migration start time after the semaphore was accquired

Previously the migration start time was captured at the start of the MigrationSourceThread which leads to aborting migrations when the VMs had too long to wait for the accquisition of the migration semaphore.

This patch captures the start time in the moment the migration really begins. Additionally this patch logs the time the migration took to accquire the migration semaphore to improve debugging of the logs.

Change-Id: I209023f5f4a3ccee5db4d43b17627b09ca55bef8 Bug-Url: https://bugzilla.redhat.com/1097298 Signed-off-by: Vinzenz Feenstra vfeenstr@redhat.com Reviewed-on: http://gerrit.ovirt.org/27135 Reviewed-by: Francesco Romani fromani@redhat.com Reviewed-by: Michal Skrivanek michal.skrivanek@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M vdsm/vm.py 1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/27637/1

diff --git a/vdsm/vm.py b/vdsm/vm.py index 2030ee6..6834c61 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -302,7 +302,8 @@ try: if self._migrationCanceledEvt: self._raiseAbortError() - self.log.debug("migration semaphore acquired") + self.log.debug("migration semaphore acquired after %d seconds", + time.time() - startTime) self._vm.conf['_migrationParams'] = { 'dst': self._dst, 'mode': self._mode, @@ -310,7 +311,7 @@ 'dstparams': self._dstparams, 'dstqemu': self._dstqemu} self._vm.saveState() - self._startUnderlyingMigration(startTime) + self._startUnderlyingMigration(time.time()) self._finishSuccessfully() except libvirt.libvirtError as e: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_ABORTED: