Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection ......................................................................
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/26300/22/vdsm/protocolDetector.py File vdsm/protocolDetector.py:
Line 88: finally: Line 89: for handler in self._handlers: Line 90: handler.stop() Line 91: Line 92: self._json_binding.stop()
It seems that this class could not care less about the bindings, and is int
Using the design above, you don't have to change this class to add or remove new binding or detectors - the class is open for extension but closed for changes. This makes it easy to test and maintain.
See http://c2.com/cgi/wiki?OpenClosedPrinciple Line 93: self._poller.unregister(self._socket) Line 94: self._poller.unregister(self._read_fd) Line 95: self._socket.close() Line 96:
vdsm-patches@lists.fedorahosted.org