5:42 a.m.
Maor Lipchuk has uploaded a new change for review.
Change subject: vdsm: Log unhandled exception for clientIF
......................................................................
vdsm: Log unhandled exception for clientIF
Adding a traceback log for unhandled exceptions,
when openning a new thread, so it will not die silently.
Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M vdsm/clientIF.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/22812/1
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index 7e6fcf8..584d77d 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -376,6 +376,7 @@
(vmParams['vmId'], container_len))
return {'status': doneCode, 'vmList': vm.status()}
+ @utils.traceback(on=self.log.name)
def _recoverThread(self):
# Trying to run recover process until it works. During that time vdsm
# stays in recovery mode (_recover=True), means all api requests
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
5:47 p.m.
New subject: Change in vdsm[master]: clientIF: Log unhandled exception for new Thread
Dan Kenigsberg has submitted this change and it was merged.
Change subject: clientIF: Log unhandled exception for new Thread
......................................................................
clientIF: Log unhandled exception for new Thread
Adding a traceback log for unhandled exceptions, when openning a new thread, so
it will not die silently. Since the log in clientIF instance is inaccessible
from the decorator, we use the default root logger.
Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22812
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/clientIF.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:46 p.m.
New subject: Change in vdsm[master]: clientIF: Log unhandled exception for new Thread
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: Log unhandled exception for new Thread
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:40 a.m.
New subject: Change in vdsm[master]: clientIF: Log unhandled exception for new Thread
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Log unhandled exception for new Thread
......................................................................
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6511/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5618/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6424/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:03 a.m.
New subject: Change in vdsm[master]: clientIF: Log unhandled exception for new Thread
Allon Mureinik has posted comments on this change.
Change subject: clientIF: Log unhandled exception for new Thread
......................................................................
Patch Set 6: Code-Review+1
+1 on the code, agree with Nir's comment about the commit message.
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-HasComments: No
3:51 p.m.
New subject: Change in vdsm[master]: clientIF: Log unhandled exception for new Thread
Nir Soffer has posted comments on this change.
Change subject: clientIF: Log unhandled exception for new Thread
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
Fix commit message when you verify?
....................................................
Commit Message
Line 6:
Line 7: clientIF: Log unhandled exception for new Thread
Line 8:
Line 9: Adding a traceback log for unhandled exceptions, when openning a new thread, so
Line 10: it will not die silently. Since the log in clientIF instance is unaccessible
inaccessible
Line 11: from the decorator, we use the default root logger.
Line 12:
Line 13: Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-HasComments: Yes
11:53 a.m.
New subject: Change in vdsm[master]: clientIF: Log unhandled exception for new Thread
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: Log unhandled exception for new Thread
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-HasComments: No
5:44 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for clientIF
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6413/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5520/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6326/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:36 a.m.
New subject: Change in vdsm[master]: clientIF: Log unhandled exception for new Thread
Maor Lipchuk has posted comments on this change.
Change subject: clientIF: Log unhandled exception for new Thread
......................................................................
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:38 a.m.
New subject: Change in vdsm[master]: clientIF: Log unhandled exception for new Thread
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Log unhandled exception for new Thread
......................................................................
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6461/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5568/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6374/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:25 a.m.
New subject: Change in vdsm[master]: clientIF: Log unhandled exception for new Thread
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Log unhandled exception for new Thread
......................................................................
Patch Set 5: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6437/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5545/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6351/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:18 a.m.
Nir Soffer has posted comments on this change.
Change subject: vdsm: Log unhandled exception for clientIF
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:17 a.m.
Nir Soffer has posted comments on this change.
Change subject: vdsm: Log unhandled exception for clientIF
......................................................................
Patch Set 4:
(2 comments)
....................................................
Commit Message
Line 3: AuthorDate: 2013-12-30 11:48:09 +0200
Line 4: Commit: Maor Lipchuk <mlipchuk(a)redhat.com>
Line 5: CommitDate: 2013-12-30 18:08:37 +0200
Line 6:
Line 7: vdsm: Log unhandled exception for clientIF
This is the vdsm project, so vdsm: prefix is redundant. clientIF: prefix would be more
helpful.
Line 8:
Line 9: Adding a traceback log for unhandled exceptions,
Line 10: when openning a new thread, so it will not die silently.
Line 11: Since the log in clientIF instance is unaccessible from the decorator,
Line 8:
Line 9: Adding a traceback log for unhandled exceptions,
Line 10: when openning a new thread, so it will not die silently.
Line 11: Since the log in clientIF instance is unaccessible from the decorator,
Line 12: we use the default root logger.
It would be nice if you wrap the lines of this paragraph. In vim, you can do this by going
into visual mode, selecting the paragraph, and pressing gq.
Line 13:
Line 14: Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10:13 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for clientIF
......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6431/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5538/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6344/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:26 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for clientIF
......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6426/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5533/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6339/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:54 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for clientIF
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6421/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5529/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6334/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:46 a.m.
New subject: Change in vdsm[master]: clientIF: Log unhandled exception for new Thread
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Log unhandled exception for new Thread
......................................................................
Patch Set 7: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6504/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5611/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6417/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595902fd9d7b62879a4466d4f8deae55a0ed7580
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3808
days inactive
3811
days old
vdsm-patches@lists.fedorahosted.org
16 comments
5 participants
participants (5)
-
Allon Mureinik -
Dan Kenigsberg -
Jenkins CI RO -
Maor Lipchuk -
Nir Soffer