Dan Kenigsberg has submitted this change and it was merged.
Change subject: mailbox: Remove fatal, uneeded, and racy check
......................................................................
mailbox: Remove fatal, uneeded, and racy check
After errors in _checkForMail, the error handling code check if the
_inLock is locked and release it. This check is pointless as
_checkForMail use try finally block to acquire and release this lock.
There is no chance that this lock will not be released when returning
from _checkForMail.
This check cause the mailbox thread to exit when using pthreading 1.3,
which reveal the fact that the locked() method was never implemented by
pthreading. This eliminate the fatal failure.
Change-Id: I46af1988a88a8aab3d9835034d68d25eec7d075d
Bug-Url:
https://bugzilla.redhat.com/1117795
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on:
http://gerrit.ovirt.org/29854
Reviewed-by: Allon Mureinik <amureini(a)redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/storage/storage_mailbox.py
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Nir Soffer: Verified
Yaniv Bronhaim: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/29854
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46af1988a88a8aab3d9835034d68d25eec7d075d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server