Royce Lv has uploaded a new change for review.
Change subject: add general test to be compatible for xmlrpc and rest ......................................................................
add general test to be compatible for xmlrpc and rest
this allow xmlrpc and rest to share common functional testcases and different binding to handle their own interface use def file to make test case dynamically changable
Change-Id: I00449f9c22800e2b00109990a7e535da986c5d48 Signed-off-by: Royce Lvlvroyce@linux.vnet.ibm.com --- M configure.ac M tests/functional/Makefile.am A tests/functional/SampleDef/Makefile.am A tests/functional/SampleDef/testBindingUp.def A tests/functional/defLoader.py A tests/functional/generalTest.py M vdsm.spec.in 7 files changed, 121 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/5308/1 -- To view, visit http://gerrit.ovirt.org/5308 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I00449f9c22800e2b00109990a7e535da986c5d48 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com
Royce Lv has posted comments on this change.
Change subject: add general test to be compatible for xmlrpc and rest ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/5308 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I00449f9c22800e2b00109990a7e535da986c5d48 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com
Adam Litke has posted comments on this change.
Change subject: add general test to be compatible for xmlrpc and rest ......................................................................
Patch Set 1: (3 inline comments)
This looks like a good start. Actually, enough of the REST API bindings are upstream that you could write a version test. For REST, you would access '/api' and for xmlrpc you would call getVdsCapabilities. It would be nice to see how your framework handles an example such as that.
.................................................... File tests/functional/defLoader.py Line 14: self.bindingType = json.loads(config.get("storage_def", "binding")) Hmm. Different tests will need to load different objects. Maybe the def files should have one section per binding and the loader simply loads all config items into the test's local variables. Then, the test case can just use the variables.
.................................................... File tests/functional/generalTest.py Line 11: class VdsmXmlRpc(TestCaseBase): Maybe VdsmXmlrpc would be better.
.................................................... File tests/functional/SampleDef/testBindingUp.def Line 2: binding = {"bindingType": "xmlrpc"} How do you plan to organize the definitions when there are multiple bindings (ie. rest)? Will you add another def file or just another section to this file?
-- To view, visit http://gerrit.ovirt.org/5308 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I00449f9c22800e2b00109990a7e535da986c5d48 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Royce Lv has posted comments on this change.
Change subject: add general test to be compatible for xmlrpc and rest ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File tests/functional/SampleDef/testBindingUp.def Line 2: binding = {"bindingType": "xmlrpc"} plan to using multiple def for one single testcase when there are multiple binding.Does that make sense?
-- To view, visit http://gerrit.ovirt.org/5308 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I00449f9c22800e2b00109990a7e535da986c5d48 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: general test framework to be compatible for xmlrpc and rest ......................................................................
Patch Set 2: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/167/
-- To view, visit http://gerrit.ovirt.org/5308 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I00449f9c22800e2b00109990a7e535da986c5d48 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: general test framework to be compatible for xmlrpc and rest ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/167/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/5308 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I00449f9c22800e2b00109990a7e535da986c5d48 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Adam Litke has posted comments on this change.
Change subject: general test framework to be compatible for xmlrpc and rest ......................................................................
Patch Set 2:
Royce,
Is this now obsolete since Zhou Zheng Sheng has submitted some new tests?
-- To view, visit http://gerrit.ovirt.org/5308 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I00449f9c22800e2b00109990a7e535da986c5d48 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Royce Lv has abandoned this change.
Change subject: general test framework to be compatible for xmlrpc and rest ......................................................................
Patch Set 2: Abandoned
-- To view, visit http://gerrit.ovirt.org/5308 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I00449f9c22800e2b00109990a7e535da986c5d48 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org