Royce Lv has uploaded a new change for review.
Change subject: remove symlink when connect local storage failed ......................................................................
remove symlink when connect local storage failed
if connectStorageServer failed for some reason, symlink remains in /rhev/data-center/mnt, which makes second failure call connectStorageServer falsely success, so remove the symlink
Change-Id: I0e44605fb6c6e2512a6aa1acefb3d1d7e09a67aa Signed-off-by: Royce Lvlvroyce@linux.vnet.ibm.com --- M vdsm/storage/storageServer.py 1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/6140/1 -- To view, visit http://gerrit.ovirt.org/6140 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I0e44605fb6c6e2512a6aa1acefb3d1d7e09a67aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com
Itamar Heim has posted comments on this change.
Change subject: remove symlink when connect local storage failed ......................................................................
Patch Set 1:
ping?
Federico Simoncelli has posted comments on this change.
Change subject: remove symlink when connect local storage failed ......................................................................
Patch Set 1:
(1 comment)
.................................................... File vdsm/storage/storageServer.py Line 418: if self.checkLink(): Line 419: return Line 420: try: Line 421: lnPath = self._getLocalPath() Line 422: os.symlink(self._path, lnPath) I suppose the "try:" should go here. Line 423: os.chmod(lnPath, 0775) Line 424: except OSError: Line 425: os.unlink(lnPath) Line 426: raise
Itamar Heim has posted comments on this change.
Change subject: remove symlink when connect local storage failed ......................................................................
Patch Set 1:
ping
Itamar Heim has posted comments on this change.
Change subject: remove symlink when connect local storage failed ......................................................................
Patch Set 1:
ping?
Itamar Heim has abandoned this change.
Change subject: remove symlink when connect local storage failed ......................................................................
Abandoned
no reply - abandoning - please restore if still relevant
vdsm-patches@lists.fedorahosted.org
-
Federico Simoncelli -
iheim＠redhat.com -
lvroyce＠linux.vnet.ibm.com