5:38 a.m.
Yaniv Bronhaim has uploaded a new change for review.
Change subject: --enable-vhostmd-hook for rhev_build script
......................................................................
--enable-vhostmd-hook for rhev_build script
vhostmd is required in rhev builds.
Change-Id: I969e813a1a02feb840a3618f205dbf0f041a121c
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M contrib/rhev_build.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/59871/1
diff --git a/contrib/rhev_build.sh b/contrib/rhev_build.sh
index d31cb6f..6f9f58c 100755
--- a/contrib/rhev_build.sh
+++ b/contrib/rhev_build.sh
@@ -9,6 +9,7 @@
--with-qemu-kvm='qemu-kvm-rhev' \
--with-qemu-img='qemu-img-rhev' \
--enable-hooks \
+ --enable-vhostmd-hook \
--disable-gluster-mgmt \
--disable-python3
make dist
--
To view, visit https://gerrit.ovirt.org/59871
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I969e813a1a02feb840a3618f205dbf0f041a121c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
5:38 a.m.
gerrit-hooks has posted comments on this change.
Change subject: --enable-vhostmd-hook for rhev_build script
......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/59871
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I969e813a1a02feb840a3618f205dbf0f041a121c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6:08 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: --enable-vhostmd-hook for rhev_build script
......................................................................
Patch Set 1: Verified+1
the error probably not related
--
To view, visit https://gerrit.ovirt.org/59871
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I969e813a1a02feb840a3618f205dbf0f041a121c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6:36 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: --enable-vhostmd-hook for rhev_build script
......................................................................
Patch Set 1: Code-Review+2 Continuous-Integration+1
and again..
FAIL: testGetDeviceByIP (network.netinfo_test.TestNetinfo)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/network/netinfo_test.py",
line 144, in testGetDeviceByIP
addresses.getDeviceByIP(addr['address'].split('/')[0]))
AssertionError: 'bond1' != 'eno2'
--
To view, visit https://gerrit.ovirt.org/59871
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I969e813a1a02feb840a3618f205dbf0f041a121c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6:37 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: --enable-vhostmd-hook for rhev_build script
......................................................................
--enable-vhostmd-hook for rhev_build script
vhostmd is required in rhev builds.
Change-Id: I969e813a1a02feb840a3618f205dbf0f041a121c
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/59871
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Continuous-Integration: Dan Kenigsberg <danken(a)redhat.com>
---
M contrib/rhev_build.sh
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Yaniv Bronhaim: Verified
Dan Kenigsberg: Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/59871
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I969e813a1a02feb840a3618f205dbf0f041a121c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6:37 a.m.
gerrit-hooks has posted comments on this change.
Change subject: --enable-vhostmd-hook for rhev_build script
......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.ovirt.org/59871
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I969e813a1a02feb840a3618f205dbf0f041a121c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
2910
days inactive
2910
days old
vdsm-patches@lists.fedorahosted.org
5 comments
3 participants
participants (3)
-
automation＠ovirt.org -
Dan Kenigsberg -
ybronhei＠redhat.com