Dan Kenigsberg has posted comments on this change.

Change subject: sosreport: Don't try to collect info from sockets ......................................................................

Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/35513/1/vdsm/sos/vdsm.py.in File vdsm/sos/vdsm.py.in:

Line 138: ) Line 139: Line 140: def _addVdsmRunDir(self): Line 141: """Add everything under /var/run/vdsm except possibly confidential Line 142: sysprep vfds and except for sockets""" English:

except possibly-confidential sysprep vfds and sockets Line 143: Line 144: import glob Line 145: Line 146: for f in glob.glob("@VDSMRUNDIR@/*"):

oVirt Jenkins CI Server has posted comments on this change.

Change subject: sosreport: Don't try to collect info from sockets ......................................................................

Patch Set 1:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12818/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13770/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_infra_functional_tests_gerrit/25/ : There was an infra issue, please contact infra@ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13607/ : SUCCESS

Yeela Kaplan has posted comments on this change.

Change subject: sosreport: Don't try to collect info from sockets ......................................................................

Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/35513/1/vdsm/sos/vdsm.py.in File vdsm/sos/vdsm.py.in:

Line 138: ) Line 139: Line 140: def _addVdsmRunDir(self): Line 141: """Add everything under /var/run/vdsm except possibly confidential Line 142: sysprep vfds and except for sockets"""

English:

Done Line 143: Line 144: import glob Line 145: Line 146: for f in glob.glob("@VDSMRUNDIR@/*"):

Line 144: import glob Line 145: Line 146: for f in glob.glob("@VDSMRUNDIR@/*"): Line 147: if not f.endswith('.vfd') and not f.endswith('/isoUploader') \ Line 148: and not f.endswith('/storage') and not f.endswith('.sock'):

maybe better something like:

Done

oVirt Jenkins CI Server has posted comments on this change.

Change subject: sosreport: Don't try to collect info from sockets ......................................................................

Patch Set 2:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13817/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13028/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13980/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_infra_functional_tests_gerrit/27/ : There was an infra issue, please contact infra@ovirt.org

Dan Kenigsberg has submitted this change and it was merged.

Change subject: sosreport: Don't try to collect info from sockets ......................................................................

sosreport: Don't try to collect info from sockets

sosreport gets an IOError trying to collect data from svdsm.sock: 'caught IO error copying /var/run/vdsm/svdsm.sock'

Change-Id: I2aa8df2a8d16c7a3468cd7cad21fe598b33b8500 Signed-off-by: Yeela Kaplan ykaplan@redhat.com Reviewed-on: http://gerrit.ovirt.org/35513 Reviewed-by: Dan Kenigsberg danken@redhat.com --- M vdsm/sos/vdsm.py.in 1 file changed, 5 insertions(+), 3 deletions(-)

Approvals: Yeela Kaplan: Verified Dan Kenigsberg: Looks good to me, approved