Change in vdsm[master]: BZ#841555 A migration failure with an "AttributeError" excep...

List overview All Threads
Download

newer

older

Change in vdsm[master]: vdsm:...

Change in vdsm[master]: Fix...

ghammer＠redhat.com

5 Aug 2012 5 Aug '12

10:30 a.m.

Gal Hammer has uploaded a new change for review.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

BZ#841555 A migration failure with an "AttributeError" exception.

Libvirt sometimes send the SUSPENDED/SUSPENDED_PAUSED event after RESUMED/RESUMED_MIGRATED (when VM status is PAUSED when migration completes, see qemuMigrationFinish function). In this case self._dom is None because the function _waitForIncomingMigrationFinish didn't update it yet.

Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070 Signed-off-by: Gal Hammer ghammer@redhat.com --- M vdsm/libvirtvm.py 1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/6901/1 -- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com

Show replies by date

Jenkins CI RO

8 Aug 8 Aug

11:03 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 1: No score

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/213/

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

11:05 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/213/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

peet＠redhat.com

10 Aug 10 Aug

10:56 a.m.

Peter V. Saveliev has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 1: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

ghammer＠redhat.com

21 Aug 21 Aug

10:33 a.m.

Gal Hammer has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 1: Verified

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

ghammer＠redhat.com

10:57 a.m.

Gal Hammer has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 1: No score

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

12:22 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 1: (1 inline comment)

.................................................... File vdsm/libvirtvm.py Line 2438: # Libvirt sometimes send the SUSPENDED/SUSPENDED_PAUSED event Line 2439: # after RESUMED/RESUMED_MIGRATED (when VM status is PAUSED Line 2440: # when migration completes, see qemuMigrationFinish function). Line 2441: # In this case self._dom is None because the function Line 2442: # _waitForIncomingMigrationFinish didn't update it yet. this comment does not reassure me... we are "sometimes" going to get this event after migration, and sometimes not? Line 2443: if self._dom: Line 2444: hooks.after_vm_pause(self._dom.XMLDesc(0), self.conf) Line 2445: elif event == libvirt.VIR_DOMAIN_EVENT_RESUMED: Line 2446: self._guestCpuRunning = True

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

ghammer＠redhat.com

12:54 p.m.

Gal Hammer has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 1: (1 inline comment)

Yes. This is what I understand from reading the qemuMigrationFinish function code. I assume that qemu pause the VM in order to finalize the migration process and *something* libvirt is fast enough to catch this state. Line 2443: if self._dom: Line 2444: hooks.after_vm_pause(self._dom.XMLDesc(0), self.conf) Line 2445: elif event == libvirt.VIR_DOMAIN_EVENT_RESUMED: Line 2446: self._guestCpuRunning = True

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

bazulay＠redhat.com

10 Sep 10 Sep

10:04 a.m.

Barak Azulay has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 1: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

10:33 a.m.

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

try: domxml = self._dom.XMLDesc(0) except AttributeError: pass else: hooks.after_vm_pause(domxml, self.conf) Line 2445: elif event == libvirt.VIR_DOMAIN_EVENT_RESUMED: Line 2446: self._guestCpuRunning = True Line 2447: if detail == libvirt.VIR_DOMAIN_EVENT_RESUMED_UNPAUSED: Line 2448: hooks.after_vm_cont(self._dom.XMLDesc(0), self.conf)

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

ghammer＠redhat.com

24 Oct 24 Oct

12:45 p.m.

Gal Hammer has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 1: (1 inline comment)

.................................................... File vdsm/libvirtvm.py Line 2440: # when migration completes, see qemuMigrationFinish function). Line 2441: # In this case self._dom is None because the function Line 2442: # _waitForIncomingMigrationFinish didn't update it yet. Line 2443: if self._dom: Line 2444: hooks.after_vm_pause(self._dom.XMLDesc(0), self.conf) I don't think that this comment is not relevant to this patch. Line 2445: elif event == libvirt.VIR_DOMAIN_EVENT_RESUMED: Line 2446: self._guestCpuRunning = True Line 2447: if detail == libvirt.VIR_DOMAIN_EVENT_RESUMED_UNPAUSED: Line 2448: hooks.after_vm_cont(self._dom.XMLDesc(0), self.conf)

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4 Jan 4 Jan

10:39 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/559/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

10:39 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/594/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:41 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/559/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/594/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

peet＠redhat.com

noon

Peter V. Saveliev has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 2: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

michal.skrivanek＠redhat.com

12 Feb 12 Feb

10:30 a.m.

Michal Skrivanek has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 2: Verified; Looks good to me, but someone else must approve

Verified by bdagan on preintegration

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

2:25 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

Patch Set 2: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

2:25 p.m.

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................

BZ#841555 A migration failure with an "AttributeError" exception.

Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070 Signed-off-by: Gal Hammer ghammer@redhat.com Signed-off-by: Vinzenz Feenstra vfeenstr@redhat.com --- M vdsm/libvirtvm.py 1 file changed, 12 insertions(+), 1 deletion(-)

Approvals: Dan Kenigsberg: Looks good to me, approved Peter V. Saveliev: Looks good to me, but someone else must approve Michal Skrivanek: Verified; Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

4154

Age (days ago)

4345

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

17 comments

6 participants

tags (0)

participants (6)

bazulay＠redhat.com
Dan Kenigsberg
ghammer＠redhat.com
Jenkins CI RO
michal.skrivanek＠redhat.com
peet＠redhat.com