Petr Horáček has uploaded a new change for review.
Change subject: spec: fix openvswitch dependency version ......................................................................
spec: fix openvswitch dependency version
= is interpreted by RPM as >=0:2, that is causing dependency problems
in CentOS where Epoch is not used. This patch changed it to >= 2.0.0
Change-Id: I23e00681e04242729125afa68f05ea7d41f27085 Signed-off-by: Petr Horáček phoracek@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/46594/1
diff --git a/vdsm.spec.in b/vdsm.spec.in index f93bcd6..a8a30f5 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -484,7 +484,7 @@ Summary: Open vSwitch support for VDSM BuildArch: noarch Requires: %{name} = %{version}-%{release} -Requires: openvswitch >= 2 +Requires: openvswitch >= 2.0.0
%description hook-ovs Hook for Open vSwitch support.
automation@ovirt.org has posted comments on this change.
Change subject: spec: fix openvswitch dependency version ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: spec: fix openvswitch dependency version ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: spec: fix openvswitch dependency version ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Sandro Bonazzola has posted comments on this change.
Change subject: spec: fix openvswitch dependency version ......................................................................
Patch Set 3: Code-Review+1
Petr Horáček has posted comments on this change.
Change subject: spec: fix openvswitch dependency version ......................................................................
Patch Set 3: Verified+1
Builded and installed OK
Sandro Bonazzola has posted comments on this change.
Change subject: spec: fix openvswitch dependency version ......................................................................
Patch Set 3:
CI won't give +1 if no code change. Please set it manually.
Dan Kenigsberg has posted comments on this change.
Change subject: spec: fix openvswitch dependency version ......................................................................
Patch Set 3: Code-Review+2
I don't mind the change, though I don't understand the dep problem. Unspecified epoch means 0 everywhere.
automation@ovirt.org has posted comments on this change.
Change subject: spec: fix openvswitch dependency version ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Dan Kenigsberg has posted comments on this change.
Change subject: spec: fix openvswitch dependency version ......................................................................
Patch Set 4: Continuous-Integration+1
Unrelated failure:
MountError: (32, ';mount: /tmp/vdsm-mkimage-testsxSVoce/images/vmId_iso.f23ce8e2c2c767ca1924f4fbeed6d3ae.img: failed to setup loop device: No such file or directory\n')
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: fix openvswitch dependency version ......................................................................
spec: fix openvswitch dependency version
In CentOS, where Epoch is not used, >= 2 is interpreted as >= 0:2, that is causing dependency problems This patch changes it to >= 2.0.0
Change-Id: I23e00681e04242729125afa68f05ea7d41f27085 Signed-off-by: Petr Horáček phoracek@redhat.com Reviewed-on: https://gerrit.ovirt.org/46594 Reviewed-by: Sandro Bonazzola sbonazzo@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com Continuous-Integration: Dan Kenigsberg danken@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved; Passed CI tests
Objections: Jenkins CI: Failed CI tests
automation@ovirt.org has posted comments on this change.
Change subject: spec: fix openvswitch dependency version ......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org
-
automation＠ovirt.org -
Dan Kenigsberg -
phoracek＠redhat.com -
Sandro Bonazzola