Change in vdsm[master]: tests: (OCD) Add space at the end of the sample string

List overview All Threads
Download

newer

older

Change in vdsm[master]: misc:...

Change in vdsm[master]: jsonrpc:...

smizrahi＠redhat.com

1 Feb 2013 1 Feb '13

10:16 p.m.

Saggi Mizrahi has uploaded a new change for review.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

tests: (OCD) Add space at the end of the sample string

When the strings are concatenated there needs to be a space or there is a punctuation sign without a space after it.

Change-Id: I1caf6c6701215cd028caf6b8052176e2be36ce2e Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M tests/testrunner.py 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/11624/1

diff --git a/tests/testrunner.py b/tests/testrunner.py index 4633168..dfe9885 100644 --- a/tests/testrunner.py +++ b/tests/testrunner.py @@ -55,7 +55,7 @@ "aute irure dolor in reprehenderit in voluptate velit esse cillum " "dolore eu fugiat nulla pariatur. Excepteur sint occaecat " "cupidatat non proident, sunt in culpa qui officia deserunt " - "mollit anim id est laborum.") + "mollit anim id est laborum. ") d, m = divmod(size, len(text)) return (text * d) + text[:m]

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: I1caf6c6701215cd028caf6b8052176e2be36ce2e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com

Show replies by date

Jenkins CI RO

1 Feb 1 Feb

10:16 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/180/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I1caf6c6701215cd028caf6b8052176e2be36ce2e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

10:16 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1069/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:16 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1034/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:18 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

Patch Set 1: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1034/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1069/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/180/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4 Feb 4 Feb

8:42 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1114/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I1caf6c6701215cd028caf6b8052176e2be36ce2e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

8:42 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/225/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

8:43 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1079/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

8:48 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

Patch Set 2: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1079/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1114/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/225/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5 Feb 5 Feb

4:23 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/271/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I1caf6c6701215cd028caf6b8052176e2be36ce2e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

4:24 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1125/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:28 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1160/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:30 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

Patch Set 3: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1125/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1160/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/271/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

agl＠us.ibm.com

6 Feb 6 Feb

6:53 p.m.

Adam Litke has posted comments on this change.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

Patch Set 3: Verified; Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I1caf6c6701215cd028caf6b8052176e2be36ce2e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

8 Feb 8 Feb

9:41 a.m.

Dan Kenigsberg has posted comments on this change.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

Patch Set 3: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I1caf6c6701215cd028caf6b8052176e2be36ce2e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Dan Kenigsberg

9:42 a.m.

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: (OCD) Add space at the end of the sample string ......................................................................

tests: (OCD) Add space at the end of the sample string

When the strings are concatenated there needs to be a space or there is a punctuation sign without a space after it.

Change-Id: I1caf6c6701215cd028caf6b8052176e2be36ce2e Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M tests/testrunner.py 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: Adam Litke: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: I1caf6c6701215cd028caf6b8052176e2be36ce2e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com

4162

Age (days ago)

4169

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

15 comments

4 participants

tags (0)

participants (4)

agl＠us.ibm.com
Dan Kenigsberg
Jenkins CI RO
smizrahi＠redhat.com