Alon Bar-Lev has uploaded a new change for review.
Change subject: build: use architecture independent location of site-packages if possible ......................................................................
build: use architecture independent location of site-packages if possible
Currently all vdsm python modules go into pyexecdir, which is the architecture specific location.
Python architecture independent modules should go into pythondir.
In x86_64 system locations are: pythondir = /usr/lib/python2.7/site-packages pyexecdir = /usr/lib64/python2.7/site-packages
Both are in default search path of python: --- print(sys.path)" ['', '/root', '/usr/lib64/python27.zip', '/usr/lib64/python2.7', '/usr/lib64/python2.7/plat-linux2', '/usr/lib64/python2.7/lib-tk', '/usr/lib64/python2.7/lib-old', '/usr/lib64/python2.7/lib-dynload', '/usr/lib64/python2.7/site-packages', '/usr/lib64/python2.7/site-packages/gst-0.10', '/usr/lib64/python2.7/site-packages/gtk-2.0', '/usr/lib/python2.7/site-packages', '/usr/lib/python2.7/site-packages/setuptools-0.6c11-py2.7.egg-info'] ---
In vdsm project only the betterPopen package is architecture specific, it should go into pyexecdir while all other packages should go into pythondir.
Change-Id: I975cab5c885697d3c43d083e243f8004587fd2bc Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M configure.ac M vdsm/betterPopen/Makefile.am 2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/6098/1 -- To view, visit http://gerrit.ovirt.org/6098 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I975cab5c885697d3c43d083e243f8004587fd2bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: build: use architecture independent location of site-packages if possible ......................................................................
Patch Set 2:
This time with spec file modification.
-- To view, visit http://gerrit.ovirt.org/6098 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I975cab5c885697d3c43d083e243f8004587fd2bc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: build: use architecture independent location of site-packages if possible ......................................................................
Patch Set 2: I would prefer that you didn't submit this
Dan, You were right.
Python searches for module at PYTHONPATH, when found it STOPS. Then all submodules are searched from this single location.
The arch specific comes first, but it does not help as it shadows the noarch.
I was surprised that the following does not work too... import module1.module2
So a better solution will be to move out the betterPopen out of the vdsm scope.
-- To view, visit http://gerrit.ovirt.org/6098 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I975cab5c885697d3c43d083e243f8004587fd2bc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has abandoned this change.
Change subject: build: use architecture independent location of site-packages if possible ......................................................................
Patch Set 2: Abandoned
Python modules cannot be split between arch specific and none-arch specific.
-- To view, visit http://gerrit.ovirt.org/6098 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I975cab5c885697d3c43d083e243f8004587fd2bc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has restored this change.
Change subject: build: use architecture independent location of site-packages if possible ......................................................................
Patch Set 2: Restored
I like to finish what I start... Optional for reference...
-- To view, visit http://gerrit.ovirt.org/6098 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: restore Gerrit-Change-Id: I975cab5c885697d3c43d083e243f8004587fd2bc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: build: use architecture independent location of site-packages if possible ......................................................................
Patch Set 3:
Can be used also if we rename the utility modules.
-- To view, visit http://gerrit.ovirt.org/6098 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I975cab5c885697d3c43d083e243f8004587fd2bc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has abandoned this change.
Change subject: build: use architecture independent location of site-packages if possible ......................................................................
Patch Set 3: Abandoned
Did this 2nd stage only to see if can be done without modifying the code of vdsm.
-- To view, visit http://gerrit.ovirt.org/6098 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I975cab5c885697d3c43d083e243f8004587fd2bc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has restored this change.
Change subject: build: use architecture independent location of site-packages if possible ......................................................................
Patch Set 3: Restored
Not splitting better* into own packages for now.
-- To view, visit http://gerrit.ovirt.org/6098 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: restore Gerrit-Change-Id: I975cab5c885697d3c43d083e243f8004587fd2bc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: build: use architecture independent location of site-packages if possible ......................................................................
Patch Set 4:
Dan, as we discussed.
This is a solution for now... we left with the safelease which is installed at /usr/libexec which is invalid for arch specific files, but this is for different patch.
-- To view, visit http://gerrit.ovirt.org/6098 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I975cab5c885697d3c43d083e243f8004587fd2bc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: build: use architecture independent location of site-packages if possible ......................................................................
Patch Set 4:
ping?
-- To view, visit http://gerrit.ovirt.org/6098 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I975cab5c885697d3c43d083e243f8004587fd2bc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: build: use architecture independent location of site-packages if possible ......................................................................
Patch Set 5:
Manual rebase, if we ever need something similar.
-- To view, visit http://gerrit.ovirt.org/6098 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I975cab5c885697d3c43d083e243f8004587fd2bc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has abandoned this change.
Change subject: build: use architecture independent location of site-packages if possible ......................................................................
Patch Set 5: Abandoned
won't happen
-- To view, visit http://gerrit.ovirt.org/6098 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I975cab5c885697d3c43d083e243f8004587fd2bc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org
-
Alon Bar-Lev