Saggi Mizrahi has uploaded a new change for review.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
jsonrpc: Properly initialize RuntimeError for JsonRpcError
Without this the error doesn't have a proper message when printed\logged
Change-Id: Ic922a25e44ddc345d54dff19ffa6a93c461c1844 Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M lib/yajsonrpc/__init__.py 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/35934/1
diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py index dcfbbda..b03151f 100644 --- a/lib/yajsonrpc/__init__.py +++ b/lib/yajsonrpc/__init__.py @@ -33,6 +33,9 @@ def __init__(self, code, msg): self.code = code self.message = msg + super(RuntimeError, self).__init__( + "[%d] %s" % (self.code, self.message) + )
class JsonRpcParseError(JsonRpcError):
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13945/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13156/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14109/ : FAILURE
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 1: Code-Review+1
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 1: Code-Review+1
automation@ovirt.org has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15979/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15178/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16149/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/955/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16340/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15540/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16510/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16447/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16618/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15647/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/35934/5//COMMIT_MSG Commit Message:
Line 5: CommitDate: 2015-03-09 17:22:22 +0100 Line 6: Line 7: jsonrpc: Properly initialize RuntimeError for JsonRpcError Line 8: Line 9: Without this the error doesn't have a proper message when printed\logged silly comment (no need to change): I don't like backward slash, I automatically think about escaping next char, not about separating word. Line 10: Line 11: Change-Id: Ic922a25e44ddc345d54dff19ffa6a93c461c1844
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/35934/5//COMMIT_MSG Commit Message:
Line 5: CommitDate: 2015-03-09 17:22:22 +0100 Line 6: Line 7: jsonrpc: Properly initialize RuntimeError for JsonRpcError Line 8: Line 9: Without this the error doesn't have a proper message when printed\logged
silly comment (no need to change): I don't like backward slash, I automatic
:-) ok. will update Line 10: Line 11: Change-Id: Ic922a25e44ddc345d54dff19ffa6a93c461c1844
automation@ovirt.org has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 6: Verified+1
Verified by running engine 3.5, host installing vdsm and checking the logs for potential issues.
automation@ovirt.org has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16652/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16823/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16752/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16924/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16783/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16955/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16860/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17032/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 11:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16962/
automation@ovirt.org has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 11:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17135/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16962/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17135/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 12: Code-Review+2
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 12:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17320/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 12:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17494/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
jsonrpc: Properly initialize RuntimeError for JsonRpcError
Without this, the error doesn't have a proper message when printed\logged
Change-Id: Ic922a25e44ddc345d54dff19ffa6a93c461c1844 Signed-off-by: Saggi Mizrahi smizrahi@redhat.com Reviewed-on: https://gerrit.ovirt.org/35934 Reviewed-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-by: Piotr Kliczewski piotr.kliczewski@gmail.com Reviewed-by: Francesco Romani fromani@redhat.com Tested-by: Piotr Kliczewski piotr.kliczewski@gmail.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M lib/yajsonrpc/__init__.py 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: Piotr Kliczewski: Verified; Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve
automation@ovirt.org has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 13:
Build Started (1/9) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4803/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17320/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17494/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 13:
Build Started (2/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_mer...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 13:
Build Started (3/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_me...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 13:
Build Started (4/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/794/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 13:
Build Started (5/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/828/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 13:
Build Started (6/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/828/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 13:
Build Started (7/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_mer...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 13:
Build Started (8/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/823/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 13:
Build Started (9/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_me...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError ......................................................................
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/823/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_me... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4803/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/794/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_mer... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/828/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_mer... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_me... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/828/ : SUCCESS
vdsm-patches@lists.fedorahosted.org