Ido Barkan has uploaded a new change for review.
Change subject: Make _upgrade_needed public. ......................................................................
Make _upgrade_needed public.
It is used from outside of vdsm-restore-net-config. Also removed redundant parentheses.
Change-Id: I9f116f0b0587382fbbb5194d4375579d3d14ee3c Signed-off-by: Ido Barkan ibarkan@redhat.com --- M lib/vdsm/tool/upgrade.py M vdsm/vdsm-restore-net-config 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/38866/1
diff --git a/lib/vdsm/tool/upgrade.py b/lib/vdsm/tool/upgrade.py index 8447745..b636d2a 100644 --- a/lib/vdsm/tool/upgrade.py +++ b/lib/vdsm/tool/upgrade.py @@ -34,7 +34,7 @@ return os.path.join(P_VDSM_LIB, 'upgrade', upgrade.name)
-def _upgrade_needed(upgrade): +def upgrade_needed(upgrade): return not os.path.exists(_upgrade_seal_path(upgrade))
@@ -85,7 +85,7 @@ if hasattr(upgrade, 'extendArgParser'): upgrade.extendArgParser(argparser) ns, args = argparser.parse_known_args(args[1:]) - if (_upgrade_needed(upgrade) or ns.runAgain): + if upgrade_needed(upgrade) or ns.runAgain: _get_upgrade_log().debug("Running upgrade %s", upgrade.name) try: upgrade.run(ns, args) diff --git a/vdsm/vdsm-restore-net-config b/vdsm/vdsm-restore-net-config index bcd3924..89877ce 100755 --- a/vdsm/vdsm-restore-net-config +++ b/vdsm/vdsm-restore-net-config @@ -163,7 +163,7 @@ """Flush vdsm configurations left-overs from any configurator on the system so that changes of configurator and persistence system are smooth. Only done if upgrade to unified persistence is not pending""" - if (not upgrade._upgrade_needed( + if (not upgrade.upgrade_needed( unified_persistence.UpgradeUnifiedPersistence)): for configurator_cls in _get_all_configurators(): configurator_cls().flush()
automation@ovirt.org has posted comments on this change.
Change subject: Make _upgrade_needed public. ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Make _upgrade_needed public. ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16825/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16997/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/280... : There was an infra issue, please contact infra@ovirt.org
automation@ovirt.org has posted comments on this change.
Change subject: Make _upgrade_needed public. ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Make _upgrade_needed public. ......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16839/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17011/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/281... : There was an infra issue, please contact infra@ovirt.org
automation@ovirt.org has posted comments on this change.
Change subject: Make _upgrade_needed public. ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Ondřej Svoboda has posted comments on this change.
Change subject: Make _upgrade_needed public. ......................................................................
Patch Set 3: Code-Review+1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Make _upgrade_needed public. ......................................................................
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16853/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17025/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/281... : There was an infra issue, please contact infra@ovirt.org
automation@ovirt.org has posted comments on this change.
Change subject: Make _upgrade_needed public. ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Make _upgrade_needed public. ......................................................................
Patch Set 4:
Build Started (1/3) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16995/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Make _upgrade_needed public. ......................................................................
Patch Set 4:
Build Started (2/3) -> http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/282...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Make _upgrade_needed public. ......................................................................
Patch Set 4:
Build Started (3/3) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17169/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Make _upgrade_needed public. ......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16995/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17169/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/282... : There was an infra issue, please contact infra@ovirt.org
Ido Barkan has abandoned this change.
Change subject: Make _upgrade_needed public. ......................................................................
Abandoned
not needed anymore
automation@ovirt.org has posted comments on this change.
Change subject: Make _upgrade_needed public. ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
vdsm-patches@lists.fedorahosted.org