Nir Soffer has uploaded a new change for review.
Change subject: multipath: Minor style cleanups ......................................................................
multipath: Minor style cleanups
Unify CommandPath constants and align the comments.
Change-Id: I11db81f7c376aaebe36cf3b764504fc123cd4866 Signed-off-by: Nir Soffer nsoffer@redhat.com --- M vdsm/storage/multipath.py 1 file changed, 6 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/40790/1
diff --git a/vdsm/storage/multipath.py b/vdsm/storage/multipath.py index 4392b41..b608c59 100644 --- a/vdsm/storage/multipath.py +++ b/vdsm/storage/multipath.py @@ -48,14 +48,13 @@
log = logging.getLogger("Storage.Multipath")
-_scsi_id = utils.CommandPath("scsi_id", - "/usr/lib/udev/scsi_id", # Fedora - "/lib/udev/scsi_id", # EL6, Ubuntu - ) +_SCSI_ID = utils.CommandPath("scsi_id", + "/usr/lib/udev/scsi_id", # Fedora, EL7 + "/lib/udev/scsi_id") # Ubuntu
_MULTIPATHD = utils.CommandPath("multipathd", - "/usr/sbin/multipathd", # Fedora, EL7 - "/sbin/multipathd") # Ubuntu + "/usr/sbin/multipathd", # Fedora, EL7 + "/sbin/multipathd") # Ubuntu
class Error(Exception): @@ -162,7 +161,7 @@
def getScsiSerial(physdev): blkdev = os.path.join("/dev", physdev) - cmd = [_scsi_id.cmd, + cmd = [_SCSI_ID.cmd, "--page=0x80", "--whitelisted", "--export",
automation@ovirt.org has posted comments on this change.
Change subject: multipath: Minor style cleanups ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Nir Soffer has posted comments on this change.
Change subject: multipath: Minor style cleanups ......................................................................
Patch Set 1: Verified+1
automation@ovirt.org has posted comments on this change.
Change subject: multipath: Minor style cleanups ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Nir Soffer has posted comments on this change.
Change subject: multipath: Minor style cleanups ......................................................................
Patch Set 2:
Make pep8 happy
Allon Mureinik has posted comments on this change.
Change subject: multipath: Minor style cleanups ......................................................................
Patch Set 2: Code-Review+1
Ala Hino has posted comments on this change.
Change subject: multipath: Minor style cleanups ......................................................................
Patch Set 2: Code-Review+1
automation@ovirt.org has posted comments on this change.
Change subject: multipath: Minor style cleanups ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Nir Soffer has posted comments on this change.
Change subject: multipath: Minor style cleanups ......................................................................
Patch Set 3: Verified+1
Freddy Rolland has posted comments on this change.
Change subject: multipath: Minor style cleanups ......................................................................
Patch Set 3: Code-Review+1
Dan Kenigsberg has posted comments on this change.
Change subject: multipath: Minor style cleanups ......................................................................
Patch Set 3: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: multipath: Minor style cleanups ......................................................................
multipath: Minor style cleanups
Unify CommandPath constants and align the comments.
Change-Id: I11db81f7c376aaebe36cf3b764504fc123cd4866 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/40790 Reviewed-by: Allon Mureinik amureini@redhat.com Reviewed-by: Ala Hino ahino@redhat.com Continuous-Integration: Jenkins CI Reviewed-by: Freddy Rolland frolland@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M vdsm/storage/multipath.py 1 file changed, 5 insertions(+), 6 deletions(-)
Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve Ala Hino: Looks good to me, but someone else must approve
automation@ovirt.org has posted comments on this change.
Change subject: multipath: Minor style cleanups ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org
-
ahino＠redhat.com -
Allon Mureinik -
automation＠ovirt.org -
Dan Kenigsberg -
frolland＠redhat.com -
Nir Soffer