Ido Barkan has uploaded a new change for review.
Change subject: removed unused parameter duplication ......................................................................
removed unused parameter duplication
Change-Id: Id25e07ef13bc5fb1a9c59794aa2c41bb77c79d7e Signed-off-by: ibarkan ibarkan@redhat.com --- M vdsm/network/api.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/35692/1
diff --git a/vdsm/network/api.py b/vdsm/network/api.py index 1fa4445..8f36b31 100755 --- a/vdsm/network/api.py +++ b/vdsm/network/api.py @@ -699,7 +699,7 @@ force = options.get('force', False) if not utils.tobool(force): logging.debug("Validating configuration") - _validateNetworkSetup(dict(networks), dict(bondings)) + _validateNetworkSetup(networks, bondings)
results = hooks.before_network_setup(_buildSetupHookDict(networks, bondings,
Dan Kenigsberg has posted comments on this change.
Change subject: removed unused parameter duplication ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35692/1//COMMIT_MSG Commit Message:
Line 3: AuthorDate: 2014-11-27 18:19:13 +0200 Line 4: Commit: ibarkan ibarkan@redhat.com Line 5: CommitDate: 2014-11-27 18:38:57 +0200 Line 6: Line 7: removed unused parameter duplication removed unused argument copies Line 8: Line 9: Change-Id: Id25e07ef13bc5fb1a9c59794aa2c41bb77c79d7e
oVirt Jenkins CI Server has posted comments on this change.
Change subject: removed unused parameter duplication ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/231... : There was an infra issue, please contact infra@ovirt.org
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13743/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12954/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13906/ : FAILURE
Ido Barkan has posted comments on this change.
Change subject: removed unused parameter duplication ......................................................................
Patch Set 1: Verified+1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: removed unused argument copies ......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13825/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13036/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13988/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/234... : There was an infra issue, please contact infra@ovirt.org
oVirt Jenkins CI Server has posted comments on this change.
Change subject: removed unused argument copies ......................................................................
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13830/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13041/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13993/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/234... : There was an infra issue, please contact infra@ovirt.org
Ido Barkan has posted comments on this change.
Change subject: removed unused argument copies ......................................................................
Patch Set 3: Verified+1
Dan Kenigsberg has posted comments on this change.
Change subject: removed unused argument copies ......................................................................
Patch Set 3: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: removed unused argument copies ......................................................................
removed unused argument copies
Change-Id: Id25e07ef13bc5fb1a9c59794aa2c41bb77c79d7e Signed-off-by: ibarkan ibarkan@redhat.com Reviewed-on: http://gerrit.ovirt.org/35692 Reviewed-by: Dan Kenigsberg danken@redhat.com --- M vdsm/network/api.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Ido Barkan: Verified Dan Kenigsberg: Looks good to me, approved
oVirt Jenkins CI Server has posted comments on this change.
Change subject: removed unused argument copies ......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_merg... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/261/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-fc20-x86_64_mer... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/478/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el7-x86_64_merg... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/276/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4270/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/283/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/285/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-fc21-x86_64_mer... : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6108/ : FAILURE
vdsm-patches@lists.fedorahosted.org