Change in vdsm[master]: migrateStatus() progress report

List overview All Threads
Download

newer

older

Change in vdsm[master]: Fix race...

Change in vdsm[master]: vdsm: fix...

peet＠redhat.com

1 Aug 2012 1 Aug '12

3:28 p.m.

Peter V. Saveliev has uploaded a new change for review.

Change subject: migrateStatus() progress report ......................................................................

migrateStatus() progress report

The percentage is based on libvirt dataTotal and dataProcessed fields of the virDomainJobInfo struct

Signed-off-by: Peter V. Saveliev peet@redhat.com Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e --- M vdsm/vm.py 1 file changed, 11 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/6824/1 -- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com

Show replies by date

wudxw＠linux.vnet.ibm.com

3 Aug 3 Aug

7:31 a.m.

Mark Wu has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 2: (1 inline comment)

.................................................... File vdsm/vm.py Line 112: self.status['progress'] = dataProcessed * 100 / dataTotal dataProcessed represents transferred page during migration, so it could become bigger than dataTotal because qemu repeats to transfer dirty pages. For this reason, dataProcessed * 100 / dataTotal can't show the real progress. I think (dataTotal - dataRemaining ) / dataTotal makes more sense.

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com

Ryan Harper

14 Sep 14 Sep

8:05 p.m.

Ryan Harper has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

.................................................... File vdsm/vm.py Line 108: libvirtVm = self._connection.lookupByUUID(self._vm.id) Line 109: # jobInfo reference: http://libvirt.org/html/libvirt-libvirt.html#virDomainJobInfo Line 110: (dataTotal, dataProcessed) = libvirtVm.jobInfo()[3,4] Line 111: # get transfer percentage Line 112: self.status['progress'] = (dataTotal - dataRemaining ) / dataTotal I see you obtain dataTotal and dataProcessed from jobInfo() where did dataRemaining get set/updated?

Also, is there a guarantee on jobInfo() return structure since we're pulling out entries 3 and 4 ... Line 113: except: Line 114: pass Line 115: return self.status Line 116:

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

Ryan Harper

20 Sep 20 Sep

9:28 p.m.

Ryan Harper has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

.................................................... File vdsm/vm.py Line 103: """ Line 104: Get the status of the migration. Line 105: """ Line 106: try: Line 107: # get a libvirt connection This is a nit pick, but we're not getting a connection, but rather a reference to the VM instance. Line 108: libvirtVm = self._connection.lookupByUUID(self._vm.id) Line 109: # jobInfo reference: http://libvirt.org/html/libvirt-libvirt.html#virDomainJobInfo Line 110: (dataTotal, dataProcessed, dataRemaining) = libvirtVm.jobInfo()[3:6] Line 111: # get transfer percentage

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

shaohef＠linux.vnet.ibm.com

21 Sep 21 Sep

4:34 a.m.

ShaoHe Feng has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

.................................................... File vdsm/vm.py Line 108: libvirtVm = self._connection.lookupByUUID(self._vm.id) Line 109: # jobInfo reference: http://libvirt.org/html/libvirt-libvirt.html#virDomainJobInfo Line 110: (dataTotal, dataProcessed, dataRemaining) = libvirtVm.jobInfo()[3:6] Line 111: # get transfer percentage Line 112: self.status['progress'] = (dataTotal - dataRemaining ) / dataTotal dataTotal is not float. so the percentage is either 0 or 1. Line 113: except: Line 114: pass Line 115: return self.status Line 116:

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

13 Dec 13 Dec

10:50 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 7:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/324/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

10:50 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 7:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/358/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:51 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 7:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/324/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/358/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

wudxw＠linux.vnet.ibm.com

14 Dec 14 Dec

1:45 p.m.

Mark Wu has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 7: I would prefer that you didn't submit this

The migration progress is calculated in MigrationMonitorThread in each migration_monitor_interval, so I think we could make it update migrate status too, then migrateStatus can make use of it directly instead of fetching info from libvirt.

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server

peet＠redhat.com

17 Dec 17 Dec

1:54 p.m.

Peter V. Saveliev has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 7:

Indeed, thanks, Mark.

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

2:21 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 8:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/376/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

2:21 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 8:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/411/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

2:25 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 8: I would prefer that you didn't submit this

Build Unstable

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/376/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/411/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

18 Dec 18 Dec

3:16 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 8:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/442/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3:16 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 8: No score

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/407/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3:18 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 8: I would prefer that you didn't submit this

Build Unstable

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/407/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/442/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

3:44 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 9:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/408/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

3:44 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 9:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/443/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3:45 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 9: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/408/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/443/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3:46 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 9:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/445/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3:46 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 9: No score

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/410/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3:48 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 9: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/410/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/445/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3:52 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 10:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/446/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

3:52 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 10:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/411/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

3:53 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 10: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/411/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/446/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:01 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 10:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/413/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:01 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 10: No score

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/448/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:03 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 10: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/413/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/448/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:23 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 11:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/414/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

4:23 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 11:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/449/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:24 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 11:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/414/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/449/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

shaohef＠linux.vnet.ibm.com

21 Dec 21 Dec

5:34 a.m.

ShaoHe Feng has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 11: Looks good to me, but someone else must approve

(1 inline comment)

.................................................... File vdsm/libvirtvm.py Line 393: self.mem_progress = 0 Line 394: Line 395: def run(self): Line 396: def calculateProgress(remaining, total): Line 397: return int(float(total - remaining) / total * 100) this is more simple. looks good to me. Line 398: Line 399: self._vm.log.debug('starting migration monitor thread') Line 400: Line 401: lastProgressTime = time.time()

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Vinzenz Feenstra

3 Jan 3 Jan

11:36 a.m.

Vinzenz Feenstra has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 11: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

8 Jan 8 Jan

11:43 a.m.

Dan Kenigsberg has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 11: (2 inline comments)

.................................................... File vdsm/libvirtvm.py Line 403: Line 404: while not self._stop.isSet(): Line 405: self._stop.wait(self._MIGRATION_MONITOR_INTERVAL) Line 406: # jobInfo reference: Line 407: # http://libvirt.org/html/libvirt-libvirt.html#virDomainJobInfo comment unrelated to this patch. Line 408: (jobType, timeElapsed, _, Line 409: dataTotal, dataProcessed, dataRemaining, Line 410: memTotal, memProcessed, memRemaining, Line 411: fileTotal, fileProcessed, _) = self._vm._dom.jobInfo()

.................................................... File vdsm/vm.py Line 116: def getStat(self): Line 117: """ Line 118: Get the status of the migration. Line 119: """ Line 120: if self._monitorThread is not None: if migration was canceled, or failed - you still report the last known progress. I am not sure it makes sense. Line 121: # fetch migration status from the monitor thread Line 122: self.status['progress'] = int( Line 123: float(self._monitorThread.data_progress + Line 124: self._monitorThread.mem_progress) / 2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

peet＠redhat.com

12:31 p.m.

Peter V. Saveliev has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 11: (2 inline comments)

.................................................... File vdsm/libvirtvm.py Line 403: Line 404: while not self._stop.isSet(): Line 405: self._stop.wait(self._MIGRATION_MONITOR_INTERVAL) Line 406: # jobInfo reference: Line 407: # http://libvirt.org/html/libvirt-libvirt.html#virDomainJobInfo if you want, I can remove it. It was written for the code of jobInfo() query which was redundant. The code was removed in early revisions of the patchset, but I left the comment — just to ease query review. Line 408: (jobType, timeElapsed, _, Line 409: dataTotal, dataProcessed, dataRemaining, Line 410: memTotal, memProcessed, memRemaining, Line 411: fileTotal, fileProcessed, _) = self._vm._dom.jobInfo()

.................................................... File vdsm/vm.py Line 116: def getStat(self): Line 117: """ Line 118: Get the status of the migration. Line 119: """ Line 120: if self._monitorThread is not None: I think, in this case the only usage of the migration status can be a kind of post mortem analisys, when where we can see, what the progress was at the time of failure. Anyway, I don't think we should remove it or set to 0/-1 whatever: there are other ways know whether the migration was failed or cancelled. Line 121: # fetch migration status from the monitor thread Line 122: self.status['progress'] = int( Line 123: float(self._monitorThread.data_progress + Line 124: self._monitorThread.mem_progress) / 2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

11 Jan 11 Jan

2:44 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 12:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/649/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

2:44 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 12:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/684/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

2:46 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 12:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/649/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/684/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

michal.skrivanek＠redhat.com

5:24 p.m.

Michal Skrivanek has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 11: (8 inline comments)

couple more comments...

.................................................... File vdsm/vm.py Line 105: config.get('vars', 'migration_downtime') Line 106: self.status = { Line 107: 'status': { Line 108: 'code': 0, Line 109: 'message': 'Migration in process'}, shouldn't it be "in progress"? Or see comment at migrate() function later Line 110: 'progress': 0} Line 111: threading.Thread.__init__(self) Line 112: self._preparingMigrationEvt = False Line 113: self._migrationCanceledEvt = False

Line 116: def getStat(self): Line 117: """ Line 118: Get the status of the migration. Line 119: """ Line 120: if self._monitorThread is not None: would agree with peet, we would like to know at what % the migration failed. Line 121: # fetch migration status from the monitor thread Line 122: self.status['progress'] = int( Line 123: float(self._monitorThread.data_progress + Line 124: self._monitorThread.mem_progress) / 2)

Line 192: ' unresponsive. Hiberanting without ' Line 193: 'desktopLock.') Line 194: break Line 195: self._vm.pause('Saving State') Line 196: else: just a log, but still - "process" Line 197: self.log.debug("migration Process begins") Line 198: self._vm.lastStatus = 'Migration Source' Line 199: Line 200: def _recover(self, message):

Line 234: self._vm.cif.teardownVolumePath(self._dstparams) Line 235: Line 236: self._vm.setDownStatus(NORMAL, "SaveState succeeded") Line 237: self.status = {'status': { Line 238: 'code': 0, pls fix indentation Line 239: 'message': 'SaveState done'}, Line 240: 'progress': 100} Line 241: Line 242: def _patchConfigForLegacy(self):

Line 255 Line 256 Line 257 Line 258 Line 259 I guess this is ok and needed to prevent jumping back since we are taking stats from libvirt. But still - if the preparation steps can take significant time(do they?) we may actually want to keep 10 hardcoded and progress would be recalculated to 10+0.9*progress

Line 277: except libvirt.libvirtError, e: Line 278: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_ABORTED: Line 279: self.status = { Line 280: 'status': { Line 281: 'code': errCode['migCancelErr'], is it ok progress is missing here? why? Line 282: 'message': 'Migration canceled'}} Line 283: raise Line 284: finally: Line 285: if '_migrationParams' in self._vm.conf:

Line 1183: self._migrationSourceThread = \ Line 1184: self.MigrationSourceThreadClass(self, **params) Line 1185: self._migrationSourceThread.start() Line 1186: check = self._migrationSourceThread.getStat() Line 1187: if check['status']['code']: since we are apparently ignoring the returncode anyway, how about getStat() before line 1185 and set the right initial message at line 109 Line 1188: return check Line 1189: return {'status': {'code': 0, Line 1190: 'message': 'Migration process starting'}} Line 1191: finally:

Line 1197: def migrateCancel(self): Line 1198: self._acquireCpuLockWithTimeout() Line 1199: try: Line 1200: self._migrationSourceThread.stop() Line 1201: return {'status': {'code': 0, also progress? Line 1202: 'message': 'Migration process stopped'}} Line 1203: except libvirt.libvirtError, e: Line 1204: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID: Line 1205: return errCode['migCancelErr']

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

michal.skrivanek＠redhat.com

5:25 p.m.

Michal Skrivanek has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 12: I would prefer that you didn't submit this

pls check comments in previous patchset

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

14 Jan 14 Jan

12:13 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 13:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/678/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

12:13 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 13:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/713/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

12:14 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 13:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/678/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/713/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

michal.skrivanek＠redhat.com

2:36 p.m.

Michal Skrivanek has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 13: I would prefer that you didn't submit this

(4 inline comments)

couple of new. And please recheck the previous comments as well. Thanks

.................................................... File vdsm/vm.py Line 215: Line 216: def _finishSuccessfully(self): Line 217: if self._mode != 'file': Line 218: self._vm.setDownStatus(NORMAL, "Migration succeeded") Line 219: self.status['status']['message'] = 'Migration done' where's the 100% progress? Line 220: else: Line 221: # don't pickle transient params Line 222: for ignoreParam in ('displayIp', 'display', 'pid'): Line 223: if ignoreParam in self._machineParams:

Line 231: self._vm.cif.teardownVolumePath(self._dstparams) Line 232: Line 233: self._vm.setDownStatus(NORMAL, "SaveState succeeded") Line 234: self.status['status']['message'] = 'SaveState done' Line 235: self.status['progress'] = 100 wrong indent. btw the previous format was more readable Line 236: Line 237: def _patchConfigForLegacy(self): Line 238: """ Line 239: Remove from the VM config drives list "cdrom" and "floppy"

Line 1190: self._migrationSourceThread = \ Line 1191: self.MigrationSourceThreadClass(self, **params) Line 1192: self._migrationSourceThread.start() Line 1193: self._migrationSourceThread.getStat() Line 1194: return self._migrationSourceThread.status you're missing the appropriate message. I think it should for the first time return "started" and then with subsequent queries return "in progress" Line 1195: finally: Line 1196: self._guestCpuLock.release() Line 1197: Line 1198: def migrateStatus(self):

Line 1201: def migrateCancel(self): Line 1202: self._acquireCpuLockWithTimeout() Line 1203: try: Line 1204: self._migrationSourceThread.stop() Line 1205: return self._migrationSourceThread.status where did the message go? Line 1206: except libvirt.libvirtError, e: Line 1207: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID: Line 1208: return errCode['migCancelErr'] Line 1209: raise

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

peet＠redhat.com

3:30 p.m.

Peter V. Saveliev has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 13: (4 inline comments)

.................................................... File vdsm/vm.py Line 215: Line 216: def _finishSuccessfully(self): Line 217: if self._mode != 'file': Line 218: self._vm.setDownStatus(NORMAL, "Migration succeeded") Line 219: self.status['status']['message'] = 'Migration done' look down. Line 220: else: Line 221: # don't pickle transient params Line 222: for ignoreParam in ('displayIp', 'display', 'pid'): Line 223: if ignoreParam in self._machineParams:

Line 231: self._vm.cif.teardownVolumePath(self._dstparams) Line 232: Line 233: self._vm.setDownStatus(NORMAL, "SaveState succeeded") Line 234: self.status['status']['message'] = 'SaveState done' Line 235: self.status['progress'] = 100 right indent. 100% progress for both cases. Line 236: Line 237: def _patchConfigForLegacy(self): Line 238: """ Line 239: Remove from the VM config drives list "cdrom" and "floppy"

Line 1190: self._migrationSourceThread = \ Line 1191: self.MigrationSourceThreadClass(self, **params) Line 1192: self._migrationSourceThread.start() Line 1193: self._migrationSourceThread.getStat() Line 1194: return self._migrationSourceThread.status no, I don't. It is in progress since the first second — I do not see the usecase of distinguishing «just started» from «started 0.1 secs ago». Line 1195: finally: Line 1196: self._guestCpuLock.release() Line 1197: Line 1198: def migrateStatus(self):

Line 1201: def migrateCancel(self): Line 1202: self._acquireCpuLockWithTimeout() Line 1203: try: Line 1204: self._migrationSourceThread.stop() Line 1205: return self._migrationSourceThread.status filled by MigrationSourceThread Line 1206: except libvirt.libvirtError, e: Line 1207: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID: Line 1208: return errCode['migCancelErr'] Line 1209: raise

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:36 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 14:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/706/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

4:36 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 14:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/741/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:41 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 14:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/706/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/741/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

michal.skrivanek＠redhat.com

18 Jan 18 Jan

10:42 a.m.

Michal Skrivanek has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 14: I would prefer that you didn't submit this

1 comment in previous changeset

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

11:02 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 15:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/825/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

11:02 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 15:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/790/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

11:05 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 15:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/790/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/825/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

11:06 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 16:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/791/ (2/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

11:06 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 16:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/826/ (1/2)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

11:08 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 16:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/791/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/826/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

peet＠redhat.com

11:08 a.m.

Peter V. Saveliev has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 16:

Michal, I was sure we discussed all issues. Ok, will try to guess which one remains.

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

michal.skrivanek＠redhat.com

1:59 p.m.

Michal Skrivanek has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 16: (1 inline comment)

.................................................... File vdsm/vm.py Line 1201: def migrateCancel(self): Line 1202: self._acquireCpuLockWithTimeout() Line 1203: try: Line 1204: self._migrationSourceThread.stop() Line 1205: return self._migrationSourceThread.status this is the place - where do you update the message here for cancellation? Line 1206: except libvirt.libvirtError as e: Line 1207: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID: Line 1208: return errCode['migCancelErr'] Line 1209: raise

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

peet＠redhat.com

3:43 p.m.

Peter V. Saveliev has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 16: (1 inline comment)

.................................................... File vdsm/vm.py Line 1201: def migrateCancel(self): Line 1202: self._acquireCpuLockWithTimeout() Line 1203: try: Line 1204: self._migrationSourceThread.stop() Line 1205: return self._migrationSourceThread.status yep, you're right. Line 1206: except libvirt.libvirtError as e: Line 1207: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID: Line 1208: return errCode['migCancelErr'] Line 1209: raise

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

shaohef＠linux.vnet.ibm.com

4:20 p.m.

ShaoHe Feng has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 16: I would prefer that you didn't submit this

(2 inline comments)

.................................................... File vdsm/libvirtvm.py Line 428: self.data_progress = calculateProgress(dataRemaining, dataTotal) Line 429: self.mem_progress = calculateProgress(memRemaining, memTotal) Line 430: Line 431: self._vm.log.info('Migration Progress: %s seconds elapsed, %s%% of' Line 432: ' data processed, %s%% of mem processed' % please do not use % format for logging. Line 433: (timeElapsed / 1000, Line 434: self.data_progress, Line 435: self.mem_progress)) Line 436:

.................................................... File vdsm/vm.py Line 121: if self._monitorThread is not None: Line 122: # fetch migration status from the monitor thread Line 123: self.status['progress'] = int( Line 124: float(self._monitorThread.data_progress + Line 125: self._monitorThread.mem_progress) / 2) now you have update the self.status.

before this patch, it was only touch in the run of migration thread.

any race? Line 126: return self.status Line 127: Line 128: def _setupVdsConnection(self): Line 129: if self._mode == 'file':

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

28 Jan 28 Jan

12:05 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 17:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/951/ (3/3)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

12:05 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 17:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/97/ (1/3)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

12:05 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 17:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/986/ (2/3)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

peet＠redhat.com

12:05 p.m.

Peter V. Saveliev has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 16: (3 inline comments)

Anyway, that's not my code and not the subject of the changeset. Line 433: (timeElapsed / 1000, Line 434: self.data_progress, Line 435: self.mem_progress)) Line 436:

Line 1201: def migrateCancel(self): Line 1202: self._acquireCpuLockWithTimeout() Line 1203: try: Line 1204: self._migrationSourceThread.stop() Line 1205: return self._migrationSourceThread.status Done Line 1206: except libvirt.libvirtError as e: Line 1207: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID: Line 1208: return errCode['migCancelErr'] Line 1209: raise

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

12:09 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 17: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/951/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/986/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/97/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Vinzenz Feenstra

3:20 p.m.

Vinzenz Feenstra has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 17: (1 inline comment)

.................................................... File vdsm/vm.py Line 1202: self._acquireCpuLockWithTimeout() Line 1203: try: Line 1204: self._migrationSourceThread.stop() Line 1205: self._migrationSourceThread.status['status']['message'] = \ Line 1206: 'Migration process canceled' cancelled Line 1207: return self._migrationSourceThread.status Line 1208: except libvirt.libvirtError as e: Line 1209: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID: Line 1210: return errCode['migCancelErr']

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Vinzenz Feenstra

3:20 p.m.

Vinzenz Feenstra has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 16: (1 inline comment)

.................................................... File vdsm/libvirtvm.py Line 428: self.data_progress = calculateProgress(dataRemaining, dataTotal) Line 429: self.mem_progress = calculateProgress(memRemaining, memTotal) Line 430: Line 431: self._vm.log.info('Migration Progress: %s seconds elapsed, %s%% of' Line 432: ' data processed, %s%% of mem processed' % Peter: He means that we should not use string formatting like this, but the pass it to logging as parameters. However as you said, it's not subject of this patch. Line 433: (timeElapsed / 1000, Line 434: self.data_progress, Line 435: self.mem_progress)) Line 436:

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

michal.skrivanek＠redhat.com

3:36 p.m.

Michal Skrivanek has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 17: Looks good to me, but someone else must approve

(1 inline comment)

.................................................... File vdsm/vm.py Line 1202: self._acquireCpuLockWithTimeout() Line 1203: try: Line 1204: self._migrationSourceThread.stop() Line 1205: self._migrationSourceThread.status['status']['message'] = \ Line 1206: 'Migration process canceled' well, we just made it "tunneling" instead of "tunnelling", following the US spelling seems to make sense Line 1207: return self._migrationSourceThread.status Line 1208: except libvirt.libvirtError as e: Line 1209: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID: Line 1210: return errCode['migCancelErr']

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:20 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 18:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/104/ (3/3)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

4:20 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 18:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/993/ (1/3)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:20 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 18:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/958/ (2/3)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

peet＠redhat.com

4:20 p.m.

Peter V. Saveliev has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 18:

last commit — just pep8 fix

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:22 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 18:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/958/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/993/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/104/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

shaohef＠linux.vnet.ibm.com

29 Jan 29 Jan

4:40 a.m.

ShaoHe Feng has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 16: (1 inline comment)

Peter: http://www.ovirt.org/Vdsm_Developers. The last rule of "Code Style" in this URL is about logging formatting. Line 433: (timeElapsed / 1000, Line 434: self.data_progress, Line 435: self.mem_progress)) Line 436:

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

shaohef＠linux.vnet.ibm.com

4:40 a.m.

ShaoHe Feng has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 18: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

peet＠redhat.com

9:21 a.m.

Peter V. Saveliev has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 16: (1 inline comment)

.................................................... File vdsm/libvirtvm.py Line 428: self.data_progress = calculateProgress(dataRemaining, dataTotal) Line 429: self.mem_progress = calculateProgress(memRemaining, memTotal) Line 430: Line 431: self._vm.log.info('Migration Progress: %s seconds elapsed, %s%% of' Line 432: ' data processed, %s%% of mem processed' % Thanks! I will prepare a small separated fix. Thanks a lot, guys. Line 433: (timeElapsed / 1000, Line 434: self.data_progress, Line 435: self.mem_progress)) Line 436:

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

5 Feb 5 Feb

3:58 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 18: I would prefer that you didn't submit this

(1 inline comment)

I'd prefer a minimalistic change, with no spelling changes and no non-urgent refactoring.

.................................................... File vdsm/libvirtvm.py Line 393: self.mem_progress = 0 Line 394: Line 395: def run(self): Line 396: def calculateProgress(remaining, total): Line 397: return int(float(total - remaining) / total * 100) is this change related to the patch? Line 398: Line 399: self._vm.log.debug('starting migration monitor thread') Line 400: Line 401: lastProgressTime = time.time()

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

peet＠redhat.com

4:03 p.m.

Peter V. Saveliev has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 18: (1 inline comment)

.................................................... File vdsm/libvirtvm.py Line 393: self.mem_progress = 0 Line 394: Line 395: def run(self): Line 396: def calculateProgress(remaining, total): Line 397: return int(float(total - remaining) / total * 100) Yes. Line 398: Line 399: self._vm.log.debug('starting migration monitor thread') Line 400: Line 401: lastProgressTime = time.time()

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

6 Feb 6 Feb

12:59 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 19:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1160/ (3/3)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

12:59 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 19:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/306/ (2/3)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

12:59 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 19:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1195/ (1/3)

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

1:02 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 19:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1160/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1195/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/306/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Vinzenz Feenstra

2:28 p.m.

Vinzenz Feenstra has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 19: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

michal.skrivanek＠redhat.com

7 Feb 7 Feb

8:38 a.m.

Michal Skrivanek has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 19: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

12:56 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 19: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

peet＠redhat.com

4:46 p.m.

Peter V. Saveliev has posted comments on this change.

Change subject: migrateStatus() progress report ......................................................................

Patch Set 19: Verified

verified with bidirectional migrations

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

9:48 p.m.

Dan Kenigsberg has submitted this change and it was merged.

Change subject: migrateStatus() progress report ......................................................................

migrateStatus() progress report

The percentage is based on libvirt dataTotal and dataRemaining fields of the virDomainJobInfo struct

Signed-off-by: Peter V. Saveliev peet@redhat.com Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e --- M vdsm/libvirtvm.py M vdsm/vm.py 2 files changed, 16 insertions(+), 7 deletions(-)

Approvals: Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Peter V. Saveliev: Verified Michal Skrivanek: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

4159

Age (days ago)

4349

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

85 comments

8 participants

tags (0)

participants (8)

Dan Kenigsberg
Jenkins CI RO
michal.skrivanek＠redhat.com
peet＠redhat.com
Ryan Harper
shaohef＠linux.vnet.ibm.com
Vinzenz Feenstra
wudxw＠linux.vnet.ibm.com