10:08 a.m.
Nir Soffer has uploaded a new change for review.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
supervdsmServer: Run sourceRouteThread in a thread
The current code was running the sourceRouteThread main function in the
main thread instead of starting it in a thread. This probably leads to
bogus message in the supervdsm log. Now the code is doing what is try
to do.
Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/supervdsmServer
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/22718/1
diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index 59df478..b3b3bff 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -407,7 +407,7 @@
log.debug("Started serving super vdsm object")
_sourceRouteThread = threading.Thread(
- target=sourceRouteThread.subscribeToInotifyLoop(),
+ target=sourceRouteThread.subscribeToInotifyLoop,
name='sourceRoute')
_sourceRouteThread.daemon = True
_sourceRouteThread.start()
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
3:32 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
Patch Set 3:
Multiple patches are a Good Thing.
I am not sure this is a bug per se. It's not the intended behavior but we have no
proof that it's actually worse.
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:22 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm/supervdsmServer
Line 407: log.debug("Started serving super vdsm object")
Line 408:
Line 409: _sourceRouteThread = threading.Thread(
Line 410: target=sourceRouteThread.subscribeToInotifyLoop,
Line 411: name='sourceRoute')
Funny.. but we need the rest of the file
Line 412: _sourceRouteThread.daemon = True
Line 413: _sourceRouteThread.start()
Line 414:
Line 415: # Python bug of thread.join() will block signal
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
2:25 p.m.
Antoni Segura Puimedon has posted comments on this change.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:24 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm/supervdsmServer
Line 407: log.debug("Started serving super vdsm object")
Line 408:
Line 409: _sourceRouteThread = threading.Thread(
Line 410: target=sourceRouteThread.subscribeToInotifyLoop,
Line 411: name='sourceRoute')
lovely. Everything from here down was dead code. Maybe we should not have it at all?
Line 412: _sourceRouteThread.daemon = True
Line 413: _sourceRouteThread.start()
Line 414:
Line 415: # Python bug of thread.join() will block signal
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10:11 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6255/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5468/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6361/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:09 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
supervdsmServer: Run sourceRouteThread in a thread
The current code was running the sourceRouteThread main function in the
main thread instead of starting it in a thread. This probably leads to
bogus message in the supervdsm log. Now the code is doing what it was
trying to do.
Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22718
Reviewed-by: Antoni Segura Puimedon <asegurap(a)redhat.com>
Reviewed-by: Ayal Baron <abaron(a)redhat.com>
Reviewed-by: Assaf Muller <amuller(a)redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Tested-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/supervdsmServer
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ayal Baron: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
Antoni Segura Puimedon: Looks good to me, but someone else must approve
Assaf Muller: Looks good to me, but someone else must approve
Dan Kenigsberg: Verified
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:09 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
Patch Set 3: Verified+1
Verified with http://gerrit.ovirt.org/#/c/22723/
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:28 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
Patch Set 3: Code-Review+1
why do you have 3 patchsets for the same change?
good catch. must be backported to ovirt-3.3, (I'd open a bug and relate it to it, to
ensure it will be tested as part of ovirt-3.3 and follow the backporting)
thanks!
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:08 a.m.
Assaf Muller has posted comments on this change.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
Patch Set 3: Code-Review+1
Nif - Please verify. You can do this by moving ovirtmgmt to static, manually removing its
source routing rules (ip rule del...) on the host, then running setupNetworks with dhcp
and verifying that source routing was successfully configured.
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:53 a.m.
Ayal Baron has posted comments on this change.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
12:20 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
Patch Set 3: -Code-Review
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6391/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5498/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6293/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:04 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
Patch Set 3: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6383/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6282/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5490/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:03 a.m.
Nir Soffer has posted comments on this change.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
Patch Set 3:
Rebase on http://gerrit.ovirt.org/22670 to fix unhandled exceptions.
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:50 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: supervdsmServer: Run sourceRouteThread in a thread
......................................................................
Patch Set 2: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6381/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6279/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5488/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/22718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3807
days inactive
3817
days old
vdsm-patches@lists.fedorahosted.org
14 comments
7 participants
participants (7)
-
abaron＠redhat.com -
amuller＠redhat.com -
asegurap＠redhat.com -
Dan Kenigsberg -
Jenkins CI RO -
Nir Soffer -
ybronhei＠redhat.com