Change in vdsm[master]: tests: Make python version configurable

List overview All Threads
Download

newer

older

Change in vdsm[master]: [WIP] AMQP...

Change in vdsm[master]: Add...

smizrahi＠redhat.com

25 Jan 2013 25 Jan '13

4:08 p.m.

Saggi Mizrahi has uploaded a new change for review.

Change subject: tests: Make python version configurable ......................................................................

tests: Make python version configurable

This is good if you want to run a debugger shell (like winpdb) instead of just running vanilla python.

Change-Id: I21986bca22088100bb88deba32e17e7dcead5b5d Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M tests/run_tests_local.sh.in 1 file changed, 5 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/11399/1

diff --git a/tests/run_tests_local.sh.in b/tests/run_tests_local.sh.in index 8f668f9..d1a6d32 100644 --- a/tests/run_tests_local.sh.in +++ b/tests/run_tests_local.sh.in @@ -1,2 +1,6 @@ #!/bin/sh -PYTHONDONTWRITEBYTECODE=1 LC_ALL=C PYTHONPATH="@builddir@/vdsm:@top_srcdir@/vdsm:@top_srcdir@/vdsm_cli:@top_srcdir@/vdsm_api:$PYTHONPATH" @PYTHON@ @top_srcdir@/tests/testrunner.py --local-modules $@ +if [ -z "$PYTHON_EXE" ]; then + PYTHON_EXE="@PYTHON@"; +fi + +PYTHONDONTWRITEBYTECODE=1 LC_ALL=C PYTHONPATH="@builddir@/vdsm:@top_srcdir@/vdsm:@top_srcdir@/vdsm_cli:@top_srcdir@/vdsm_api:$PYTHONPATH" $PYTHON_EXE @top_srcdir@/tests/testrunner.py --local-modules $@

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: I21986bca22088100bb88deba32e17e7dcead5b5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com

Show replies by date

Jenkins CI RO

25 Jan 25 Jan

4:08 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Make python version configurable ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/59/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I21986bca22088100bb88deba32e17e7dcead5b5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

4:08 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Make python version configurable ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/914/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:08 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Make python version configurable ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/949/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:10 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Make python version configurable ......................................................................

Patch Set 1: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/914/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/949/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/59/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

10:15 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: tests: Make python version configurable ......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

.................................................... File tests/run_tests_local.sh.in Line 1: #!/bin/sh Line 2: if [ -z "$PYTHON_EXE" ]; then Line 3: PYTHON_EXE="@PYTHON@"; but tabs are evil. Line 4: fi Line 5:

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

10:16 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: tests: Make python version configurable ......................................................................

Patch Set 1:

and for completeness, the same should apply to run_tests.sh.in.

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

26 Jan 26 Jan

5:27 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Make python version configurable ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/930/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I21986bca22088100bb88deba32e17e7dcead5b5d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

5:27 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Make python version configurable ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/75/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:27 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Make python version configurable ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/965/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:29 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Make python version configurable ......................................................................

Patch Set 2: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/930/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/965/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/75/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

smizrahi＠redhat.com

2:35 p.m.

Saggi Mizrahi has posted comments on this change.

Change subject: tests: Make python version configurable ......................................................................

Patch Set 2: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

asegurap＠redhat.com

27 Jan 27 Jan

2:40 a.m.

Antoni Segura Puimedon has posted comments on this change.

Change subject: tests: Make python version configurable ......................................................................

Patch Set 2: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I21986bca22088100bb88deba32e17e7dcead5b5d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com

Dan Kenigsberg

5:52 a.m.

Dan Kenigsberg has posted comments on this change.

Change subject: tests: Make python version configurable ......................................................................

Patch Set 2: Verified; Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I21986bca22088100bb88deba32e17e7dcead5b5d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com

Dan Kenigsberg

5:52 a.m.

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Make python version configurable ......................................................................

tests: Make python version configurable

This is good if you want to run a debugger shell (like winpdb) instead of just running vanilla python.

Change-Id: I21986bca22088100bb88deba32e17e7dcead5b5d Signed-off-by: Saggi Mizrahi smizrahi@redhat.com Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/run_tests.sh.in M tests/run_tests_local.sh.in 2 files changed, 10 insertions(+), 2 deletions(-)

Approvals: Saggi Mizrahi: Looks good to me, but someone else must approve Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/11399 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: I21986bca22088100bb88deba32e17e7dcead5b5d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com

4172

Age (days ago)

4173

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

14 comments

4 participants

tags (0)

participants (4)

asegurap＠redhat.com
Dan Kenigsberg
Jenkins CI RO
smizrahi＠redhat.com