Dan Kenigsberg has posted comments on this change.
Change subject: Adding vdsm.conf.example to rhel build
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24945/2/vdsm.spec.in
File vdsm.spec.in:
Line 666: # dropbox for core dumps
Line 667: install -dDm 1777 %{buildroot}%{_localstatedir}/log/core
Line 668: %endif
Line 669:
Line 670: install -Dm 0644 lib/vdsm/vdsm.conf.sample \
I'd prefer Federoico to remind us why we need to ship the sample
within /et
on irc, I'm told by Fedeerico and Toni that shipping
/etc/vdsm/vdsm.conf is a "best parctice". Fine. But if so, it should be
installed in Makefile.am, not here specifically for rpms.
Line 671: %{buildroot}%{_sysconfdir}/%{vdsm_name}/vdsm.conf
Line 672:
Line 673: # Install the polkit for libvirt
Line 674: %if 0%{?fedora} >= 18 || 0%{?rhel} >= 7
--
To view, visit
http://gerrit.ovirt.org/24945
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2606c571cd6de06eee811bbd340a790f98d11907
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes