Change in vdsm[master]: vdsm.spec: load needed modules

List overview All Threads
Download

newer

older

Change in vdsm[master]: Probe cpu...

Change in vdsm[master]: BZ#836161...

Douglas Schilling Landgraf

1 Feb 2013 1 Feb '13

6:54 a.m.

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: vdsm.spec: load needed modules ......................................................................

vdsm.spec: load needed modules

if bridge module is not loaded net.bridge.bridge-nf-call-* is ignored by sysctl.

Change-Id: I4102e68f89256d48a3bbb6169f6ddd4c2640fecd Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/11617/1

diff --git a/vdsm.spec.in b/vdsm.spec.in index 7cccfd4..b1bcb3c 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -493,6 +493,7 @@ %{_bindir}/vdsm-tool sebool-config || : # set the vdsm "secret" password for libvirt %{_bindir}/vdsm-tool set-saslpasswd +%{_bindir}/vdsm-tool load-needed-modules

# Have moved vdsm section in /etc/sysctl.conf to /etc/sysctl.d/vdsm. # So Remove them if it is played with /etc/sysctl.conf.

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: I4102e68f89256d48a3bbb6169f6ddd4c2640fecd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com

Show replies by date

Jenkins CI RO

1 Feb 1 Feb

6:54 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm.spec: load needed modules ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1063/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

6:54 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm.spec: load needed modules ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/174/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

6:54 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm.spec: load needed modules ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1028/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Douglas Schilling Landgraf

6:55 a.m.

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec: load needed modules ......................................................................

Patch Set 1: Verified

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I4102e68f89256d48a3bbb6169f6ddd4c2640fecd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dafna Ron dron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

6:56 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm.spec: load needed modules ......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1028/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1063/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/174/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

11:57 a.m.

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.spec: load needed modules ......................................................................

Patch Set 1: I would prefer that you didn't submit this

why is this patch needed? it is not considered very polite to change the kernel state on rpm install. why wasn't the former patch enough?

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Douglas Schilling Landgraf

3:42 p.m.

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec: load needed modules ......................................................................

Patch Set 1:

because in upstream sysctl call moved to spec file.

commit c737fa2afa085c007478f932e6f09f9c4b140f18

Replace configure_sysctl with /etc/sysctl.d/vdsm

To be simple, replace configure_sysctl in vdsmd.init with /etc/sysctl.d/vdsm

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

2 Feb 2 Feb

12:18 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.spec: load needed modules ......................................................................

Patch Set 1:

so we need to `modprobe bridge` before /etc/sysctl.d/vdsm is read. However %post is not good as it happens only once - not during each boot (think ovirt-node too).

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Douglas Schilling Landgraf

3 Feb 3 Feb

11:42 a.m.

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec: load needed modules ......................................................................

Patch Set 1:

agreed, we do need to revert it.

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

12:17 p.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl call

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Move sysctl call ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/192/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I4102e68f89256d48a3bbb6169f6ddd4c2640fecd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dafna Ron dron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

12:17 p.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl call

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Move sysctl call ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1081/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

12:17 p.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl call

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Move sysctl call ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1046/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

12:20 p.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl call

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Move sysctl call ......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1046/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1081/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/192/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

12:29 p.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl call

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Move sysctl call ......................................................................

Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

.................................................... File vdsm/vdsmd.init.in Line 475: return $ret_val Line 476: fi Line 477: Line 478: @VDSMDIR@/vdsm-restore-net-config Line 479: /usr/bin/vdsm-tool load-needed-modules this change is a step in the right direction, but wouldn't it be better to avoid load-needed-modules completely, and use /etc/modules-load.d/vdsm.conf where systemd is available? Then the modules would (hopefully) already be in when sysctl.d is processed. Line 480: /sbin/sysctl -q -p /etc/sysctl.d/vdsm Line 481: mk_data_center Line 482: mk_core_path Line 483: mk_dom_backup

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Douglas Schilling Landgraf

4 Feb 4 Feb

10:21 a.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl call

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm: Move sysctl call ......................................................................

Patch Set 2: (1 inline comment)

.................................................... File vdsm/vdsmd.init.in Line 475: return $ret_val Line 476: fi Line 477: Line 478: @VDSMDIR@/vdsm-restore-net-config Line 479: /usr/bin/vdsm-tool load-needed-modules agreed, can we do it in a different patch? Line 480: /sbin/sysctl -q -p /etc/sysctl.d/vdsm Line 481: mk_data_center Line 482: mk_core_path Line 483: mk_dom_backup

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:25 a.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Move sysctl ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1075/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I4102e68f89256d48a3bbb6169f6ddd4c2640fecd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dafna Ron dron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

10:25 a.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Move sysctl ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/221/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:25 a.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Move sysctl ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1110/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Douglas Schilling Landgraf

10:25 a.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm: Move sysctl ......................................................................

Patch Set 3: Verified

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:30 a.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Move sysctl ......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1075/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1110/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/221/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5 Feb 5 Feb

5:21 p.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Move sysctl ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/296/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: I4102e68f89256d48a3bbb6169f6ddd4c2640fecd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dafna Ron dron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

5:21 p.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Move sysctl ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1185/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:21 p.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Move sysctl ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1150/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Douglas Schilling Landgraf

5:21 p.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm: Move sysctl ......................................................................

Patch Set 4: Verified

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:23 p.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Move sysctl ......................................................................

Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1150/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1185/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/296/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

6 Feb 6 Feb

12:08 a.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Move sysctl ......................................................................

Patch Set 4: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

12:26 a.m.

New subject: Change in vdsm[master]: vdsm: Move sysctl

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm: Move sysctl ......................................................................

vdsm: Move sysctl

sysctl should be called at boot time.

Change-Id: I4102e68f89256d48a3bbb6169f6ddd4c2640fecd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=907086 Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com --- M vdsm.spec.in M vdsm/vdsmd.init.in 2 files changed, 1 insertion(+), 3 deletions(-)

Approvals: Douglas Schilling Landgraf: Verified Dan Kenigsberg: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/11617 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: I4102e68f89256d48a3bbb6169f6ddd4c2640fecd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dafna Ron dron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

4162

Age (days ago)

4167

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

27 comments

3 participants

tags (0)

participants (3)

Dan Kenigsberg
Douglas Schilling Landgraf
Jenkins CI RO