Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
......................................................................
Patch Set 16: (1 inline comment)
....................................................
File vdsm/netconf/ifcfg.py
Line 88: if network:
Line 89: self.configWriter.createLibvirtNetwork(network, False, vlan.name)
Line 90: self._libvirtAdded.add(network)
Line 91:
Line 92: def configureBond(self, bond, network=None, bridge=None, vlan=None,
it looks the parameter vlan is useless here.
Line 93: **opts):
Line 94: ipaddr, netmask, gateway, bootproto, async = bond.getIpConfig()
Line 95: self.configWriter.addBonding(bond.name, bridge=bridge,
Line 96: bondingOptions=bond.options,
--
To view, visit
http://gerrit.ovirt.org/14303
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server