Change in vdsm[master]: I ran into a problem when running 'make rpm' in Fedora 18 *w...

List overview All Threads
Download

newer

older

Change in vdsm[master]: doc:...

Change in vdsm[master]: Adding...

amuller＠redhat.com

30 Jan 2013 30 Jan '13

4:07 a.m.

Assaf Muller has uploaded a new change for review.

Change subject: I ran into a problem when running 'make rpm' in Fedora 18 *without* root access. The ConfigWriterTests:testPersistantBackup fails, because it uses libvirt's createNetwork and removeNetwork functions, but libvirt requires root access. The current solution ......................................................................

I ran into a problem when running 'make rpm' in Fedora 18 *without* root access. The ConfigWriterTests:testPersistantBackup fails, because it uses libvirt's createNetwork and removeNetwork functions, but libvirt requires root access. The current solution is to use monkey patch, and simply nullify the create and remove network functions. The test now passes, but this might not be the ideal solution to the problem.

Signed-off-by: Assaf Muller amuller@redhat.com Change-Id: Ic2e0076e146c57228eee3cca8b57948fb82bcbb7 --- M tests/configNetworkTests.py 1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/11545/1

diff --git a/tests/configNetworkTests.py b/tests/configNetworkTests.py index 0a129b9..722db6c 100644 --- a/tests/configNetworkTests.py +++ b/tests/configNetworkTests.py @@ -28,7 +28,7 @@ import pwd

import configNetwork -from vdsm import netinfo +from vdsm import netinfo, libvirtconnection from vdsm.utils import memoized

from testrunner import VdsmTestCase as TestCaseBase @@ -325,6 +325,8 @@ os.path.join(self._tempdir, 'ifcfg-')), (configNetwork, 'ifdown', lambda x: 0), (configNetwork, 'ifup', lambda *x: 0), + (configNetwork.ConfigWriter, '_createNetwork', lambda *x: None), + (configNetwork.ConfigWriter, '_removeNetwork', lambda *x: None), ]): #after vdsm package is installed, the 'vdsm' account will be #created if no 'vdsm' account, we should skip this test

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: Ic2e0076e146c57228eee3cca8b57948fb82bcbb7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amuller@redhat.com

Show replies by date

Jenkins CI RO

30 Jan 30 Jan

4:07 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/139/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ic2e0076e146c57228eee3cca8b57948fb82bcbb7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amuller@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

4:07 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1028/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:07 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/993/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:10 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Patch Set 1: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/993/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1028/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/139/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:13 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/140/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ic2e0076e146c57228eee3cca8b57948fb82bcbb7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amuller@redhat.com Gerrit-Reviewer: Assaf Muller amuller@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

4:13 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/994/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:13 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1029/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:15 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 2: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/994/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1029/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/140/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:47 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/995/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ic2e0076e146c57228eee3cca8b57948fb82bcbb7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amuller@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Assaf Muller amuller@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

4:47 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1030/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:47 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/141/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:50 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/995/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1030/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/141/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

31 Jan 31 Jan

10:04 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

Dan Kenigsberg has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

I do wonder why I do not see the problem in my account or via jenkins.

.................................................... Commit Message Line 5: CommitDate: 2013-01-30 14:47:21 +0200 Line 6: Line 7: Issue when running make rpm in Fedora 18 without root access. Line 8: Line 9: The ConfigWriterTests:testPersistantBackup fails, because it uses libvirt's createNetwork and removeNetwork functions, but libvirt requires root access. The current solution is to use monkey patch, and simply nullify the create and remove network functions. The test now passes, but this might not be the ideal solution to the problem. please break message lines at the 80 char mark Line 10: Line 11: Signed-off-by: Assaf Muller amuller@redhat.com

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

asegurap＠redhat.com

3 Feb 3 Feb

6 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

Antoni Segura Puimedon has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 3: I would prefer that you didn't submit this

Could you try to find a way to reproduce it in a new machine? I can reproduce it on mine if I create a secondary user account, for example. The good thing would be if you would be able to single out the cause of the bug.

For the rest, I'm fine with taking this in.

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

14 Feb 14 Feb

7 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1240/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ic2e0076e146c57228eee3cca8b57948fb82bcbb7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amuller@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Assaf Muller amuller@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

7 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/386/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1275/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7:03 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1240/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1275/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/386/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

asegurap＠redhat.com

7:15 a.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

Antoni Segura Puimedon has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 4: Looks good to me, but someone else must approve

Even if it doesn't fail for some users, we don't have any business in trying to create nets in libvirt (in the context of a unit test).

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

12:19 p.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

Dan Kenigsberg has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Patch Set 4: Verified; Looks good to me, approved

I suppose we can live by now without understanding the underlying issue.

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

12:19 p.m.

New subject: Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Issue when running make rpm in Fedora 18 without root access. ......................................................................

Issue when running make rpm in Fedora 18 without root access.

The ConfigWriterTests:testPersistantBackup fails, because it uses libvirt's createNetwork and removeNetwork functions, but libvirt requires root access. The current solution is to use monkey patch, and simply nullify the create and remove network functions. The test now passes, but this might not be the ideal solution to the problem.

Signed-off-by: Assaf Muller amuller@redhat.com Change-Id: Ic2e0076e146c57228eee3cca8b57948fb82bcbb7 --- M tests/configNetworkTests.py 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/11545 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: Ic2e0076e146c57228eee3cca8b57948fb82bcbb7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amuller@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Assaf Muller amuller@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server

4154

Age (days ago)

4169

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

21 comments

4 participants

tags (0)

participants (4)

amuller＠redhat.com
asegurap＠redhat.com
Dan Kenigsberg
Jenkins CI RO