Royce Lv has uploaded a new change for review.
Change subject: schema: nit fixes in vm definition ......................................................................
schema: nit fixes in vm definition
delete displayPort and displaySecurePort in vmdef These two ports are selected by libvirt according to API.py Add boot to vmDef
Change-Id: I14c8f2919390d65a6938b6aadfb09fb2419f74bc Signed-off-by: Royce Lvlvroyce@linux.vnet.ibm.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 5 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/8487/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json index e3a1c2a..1c61e36 100644 --- a/vdsm_api/vdsmapi-schema.json +++ b/vdsm_api/vdsmapi-schema.json @@ -2289,6 +2289,8 @@ # # @acpiEnable: Indicates if ACPI is enabled inside the VM # +# @boot: #optional An alias for the type of device used to boot the VM +# # @clientIp: The IP address of the client connected to the display # # @cpuPinning: #optional Information about CPU pinning @@ -2302,10 +2304,6 @@ # @display: The type of display # # @displayIp: The IP address to use for accessing the VM display -# -# @displayPort: The port in use for unencrypted display data -# -# @displaySecurePort: The port in use for encrypted display data # # @emulatedMachine: The specific machine specification being emulated # @@ -2345,8 +2343,9 @@ # Since: 4.10.0 ## {'type': 'VmFullStatus', - 'data': {'acpiEnable': 'bool', 'clientIp': 'str', '*cpuPinning': 'CpuPinInfoMap', - 'cpuType': 'str', 'custom': 'StringMap', 'devices': ['VmDevice'], + 'data': {'acpiEnable': 'bool', 'clientIp': 'str', '*boot': 'VmBootMode', + '*cpuPinning': 'CpuPinInfoMap', 'cpuType': 'str', + 'custom': 'StringMap', 'devices': ['VmDevice'], 'display': 'VmDisplayType', 'displayIp': 'str', 'displayPort': 'uint', 'displaySecurePort': 'uint', 'emulatedMachine': 'str', 'keyboardLayout': 'str',
-- To view, visit http://gerrit.ovirt.org/8487 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I14c8f2919390d65a6938b6aadfb09fb2419f74bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com
Adam Litke has posted comments on this change.
Change subject: schema: nit fixes in vm definition ......................................................................
Patch Set 1: I would prefer that you didn't submit this
Hi Royce. Please see http://gerrit.ovirt.org/#/c/7839/ . I think the parameters used to create a VM are different enough from the definition of an existing VM. Therefore, I am recommending we split them and create a new VmParameters type.
-- To view, visit http://gerrit.ovirt.org/8487 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I14c8f2919390d65a6938b6aadfb09fb2419f74bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com
Royce Lv has abandoned this change.
Change subject: schema: nit fixes in vm definition ......................................................................
Patch Set 1: Abandoned
fixed
-- To view, visit http://gerrit.ovirt.org/8487 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I14c8f2919390d65a6938b6aadfb09fb2419f74bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com
vdsm-patches@lists.fedorahosted.org