Yaniv Bronhaim has posted comments on this change.

Change subject: xmlrpc: Parsing error logging enhancement ......................................................................

Patch Set 4:

(2 comments)

looks good. adding mooli and saggi to review and some comments

thanks.

.................................................... File .gitignore Line 55 Line 56 Line 57 Line 58 Line 59 not related to the patch and wrong to omit, please undo

we need to ignore the py, the py.in is part of the repository

.................................................... File lib/vdsm/vdscli.py.in Line 34: Line 35: Line 36: class TransportWrapper: Line 37: def __init__(self, transport): Line 38: self.transport = transport for private vars use _ prefix Line 39: Line 40: def __getattr__(self, name): Line 41: if hasattr(self.transport, name): Line 42: func = getattr(self.transport, name)