Hello Adam Litke, Shahar Havivi, Dan Kenigsberg, Francesco Romani,

I'd like you to do a code review. Please visit

https://gerrit.ovirt.org/45737

to review the following change.

Change subject: v2v: Try to be nicer to other processes ......................................................................

v2v: Try to be nicer to other processes

Under the hood, virt-v2v is running qemu-img convert. We use high nice and ionice values when running qemu-img convert, but we did not specify such options when running virt-v2v. This patch run virt-v2v with the same setting uses for qemu-img convert.

Change-Id: Id163844a5976384ca9e9a75d58a581645f08a89f Backport-To: 3.6 Relates-To: https://bugzilla.redhat.com/1243935 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/43817 Continuous-Integration: Jenkins CI Reviewed-by: Adam Litke alitke@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com Reviewed-by: Francesco Romani fromani@redhat.com Reviewed-by: Shahar Havivi shavivi@redhat.com --- M vdsm/v2v.py 1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/45737/1

diff --git a/vdsm/v2v.py b/vdsm/v2v.py index d0bcc3a..cdd831b 100644 --- a/vdsm/v2v.py +++ b/vdsm/v2v.py @@ -40,7 +40,7 @@ from vdsm.define import errCode, doneCode from vdsm import libvirtconnection, response from vdsm.infra import zombiereaper -from vdsm.utils import traceback, CommandPath, execCmd +from vdsm.utils import traceback, CommandPath, execCmd, NICENESS, IOCLASS

import caps

@@ -418,7 +418,10 @@ cmd = self._create_command() logging.info('Job %r starting import', self._id)

+ # This is the way we run qemu-img convert jobs. virt-v2v is invoking + # qemu-img convert to perform the migration. self._proc = execCmd(cmd, sync=False, deathSignal=signal.SIGTERM, + nice=NICENESS.HIGH, ioclass=IOCLASS.IDLE, env=self._execution_environments())

self._proc.blocking = True