Piotr Kliczewski has uploaded a new change for review.
Change subject: events: send event explicitly after vm was started ......................................................................
events: send event explicitly after vm was started
We need to make sure that we send 'PoweringUp' status. After we moved event send logic from _set_lastStatus to ClientIf we no longer send it.
Change-Id: I14e42510fd79796b7587390817a1c1a45773b00f Signed-off-by: pkliczewski piotr.kliczewski@gmail.com --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/42580/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 25a9b10..effe69d 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -780,6 +780,7 @@ else: self.log.exception("The vm start process failed") self.setDownStatus(ERROR, vmexitreason.GENERIC_ERROR, str(e)) + self.send_status_event()
def _incomingMigrationPending(self): return 'migrationDest' in self.conf or 'restoreState' in self.conf
automation@ovirt.org has posted comments on this change.
Change subject: events: send event explicitly after vm was started ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Piotr Kliczewski has posted comments on this change.
Change subject: events: send event explicitly after vm was started ......................................................................
Patch Set 1: Verified+1
Verified by using latest engine and vdsm and seeing 'PoweringUp' event being triggered during vm start.
Dan Kenigsberg has posted comments on this change.
Change subject: events: send event explicitly after vm was started ......................................................................
Patch Set 1: Code-Review+2
automation@ovirt.org has posted comments on this change.
Change subject: events: send event explicitly after vm was started ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Arik Hadas has posted comments on this change.
Change subject: events: send event explicitly after vm was started ......................................................................
Patch Set 2: Verified+1
with no polls, VM status is now switched to PoweringUp. Note that in such setup and without guest agent, the VM will stay in PoweringUp (and will not change to Up) but that's ok since in a typical setup it will change to Up in the next poll (so instead of 1 minute, it will take 75 secs in the worst case)
Dan Kenigsberg has submitted this change and it was merged.
Change subject: events: send event explicitly after vm was started ......................................................................
events: send event explicitly after vm was started
We need to make sure that we send 'PoweringUp' status. After we moved event send logic from _set_lastStatus to ClientIf we no longer send it.
Change-Id: I14e42510fd79796b7587390817a1c1a45773b00f Signed-off-by: pkliczewski piotr.kliczewski@gmail.com Reviewed-on: https://gerrit.ovirt.org/42580 Reviewed-by: Dan Kenigsberg danken@redhat.com Continuous-Integration: Jenkins CI Tested-by: Arik Hadas ahadas@redhat.com --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Arik Hadas: Verified
automation@ovirt.org has posted comments on this change.
Change subject: events: send event explicitly after vm was started ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org
-
ahadas＠redhat.com -
automation＠ovirt.org -
Dan Kenigsberg -
Piotr Kliczewski