Yaniv Bronhaim has uploaded a new change for review.
Change subject: Change expected behaviour for vdsmd reconfigure
......................................................................
Change expected behaviour for vdsmd reconfigure
Vdsmd reconfigure is mainly used by deploy tools for backward
compatibility. Currently without "force" flag it won't reconfigure
libvirt in the deploy process if the configuration is already exist.
The users expect the configuration to be overrided with defaults after
fresh deploy.
This patch omit the check for force flag and force the reconfigure each
call for vdsmd reconfigure.
Change-Id: I1d2d550cdec8421765a7c47750f24232e60b3f67
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1043227
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M init/sysvinit/vdsmd.init.in
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/22838/1
diff --git a/init/sysvinit/vdsmd.init.in b/init/sysvinit/vdsmd.init.in
index 6ef5718..30a5f0b 100755
--- a/init/sysvinit/vdsmd.init.in
+++ b/init/sysvinit/vdsmd.init.in
@@ -100,9 +100,7 @@
}
reconfigure() {
- if [ "${1}" = "force" ] || ! "$VDSM_TOOL"
is-configured; then
- "$VDSM_TOOL" configure "--force"
- fi
+ "$VDSM_TOOL" configure "--force"
}
start() {
@@ -196,7 +194,7 @@
reconfigure)
# Jump over 'reconfigure'
shift 1
- reconfigure "$@"
+ reconfigure
RETVAL=$?
;;
*)
--
To view, visit
http://gerrit.ovirt.org/22838
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d2d550cdec8421765a7c47750f24232e60b3f67
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>