Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding --with-local-version flag to configure ......................................................................
Adding --with-local-version flag to configure
Change-Id: I93dcd1abed31babceb3e36d07ac994765203a0be Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com --- M configure.ac M vdsm.spec.in 2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/35202/1
diff --git a/configure.ac b/configure.ac index df133e6..dedad19 100644 --- a/configure.ac +++ b/configure.ac @@ -78,6 +78,13 @@ AC_SUBST([ENABLE_LIBVIRT_SELINUX], ["${enable_libvirt_selinux}"])
AC_ARG_WITH( + [local-version], + [AS_HELP_STRING([--with-local-version], [local version to use])], + [LOCAL_VERSION="${withval}"], + [LOCAL_VERSION=""] +) + +AC_ARG_WITH( [qemu-user], [AS_HELP_STRING( [--with-qemu-user=USER], diff --git a/vdsm.spec.in b/vdsm.spec.in index 4ac6747..2725e6d 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -672,7 +672,9 @@ %if 0%{?enable_autotools} autoreconf -if %endif -%configure %{?with_hooks:--enable-hooks} +%configure \ + %{?with_hooks:--enable-hooks} \ + --with-local-version="%{name}-%{version}-%{release}" make # Setting software_version and software_revision in dsaversion.py baserelease=`echo "%{release}" | sed 's/([0-9]+(.[0-9]+)?).*/\1/'`
Alon Bar-Lev has posted comments on this change.
Change subject: Adding --with-local-version flag to configure ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35202/1/configure.ac File configure.ac:
Line 80: AC_ARG_WITH( Line 81: [local-version], Line 82: [AS_HELP_STRING([--with-local-version], [local version to use])], Line 83: [LOCAL_VERSION="${withval}"], Line 84: [LOCAL_VERSION=""] you should subst this so that we can inject it into template, and use this within --version output and vdsmd / svdsmd logs on startup. Line 85: ) Line 86: Line 87: AC_ARG_WITH( Line 88: [qemu-user],
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding --with-local-version flag to configure ......................................................................
Patch Set 2: Verified+1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding --with-local-version flag to configure ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12628/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/38/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13580/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/34/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/599/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/580... : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/194/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13418/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding --with-local-version flag to configure ......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12629/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/39/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13581/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/35/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/600/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/581... : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/195/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13419/ : SUCCESS
Yaniv Bronhaim has abandoned this change.
Change subject: Adding --with-local-version flag to configure ......................................................................
Abandoned
automation@ovirt.org has posted comments on this change.
Change subject: Adding --with-local-version flag to configure ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
vdsm-patches@lists.fedorahosted.org