Hello Vinzenz Feenstra,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: vdsm: fix tunneled migration regression ......................................................................
vdsm: fix tunneled migration regression
Change-Id: I8958d7a6ba7b48f2390acab7b300cf4e539a550c Signed-off-by: Peter V. Saveliev peet@redhat.com Signed-off-by: Vinzenz Feenstra vfeenstr@redhat.com --- M vdsm/libvirtvm.py 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/11853/1
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py index fb959be..0b09883 100644 --- a/vdsm/libvirtvm.py +++ b/vdsm/libvirtvm.py @@ -489,7 +489,8 @@ duri, muri, None, libvirt.VIR_MIGRATE_LIVE | libvirt.VIR_MIGRATE_PEER2PEER | - libvirt.VIR_MIGRATE_TUNNELLED if self._tunneled else 0, + (libvirt.VIR_MIGRATE_TUNNELLED if + self._tunneled else 0), None, maxBandwidth) finally: t.cancel()
-- To view, visit http://gerrit.ovirt.org/11853 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I8958d7a6ba7b48f2390acab7b300cf4e539a550c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: fix tunneled migration regression ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/322/ (1/3)
-- To view, visit http://gerrit.ovirt.org/11853 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8958d7a6ba7b48f2390acab7b300cf4e539a550c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: fix tunneled migration regression ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1211/ (3/3)
-- To view, visit http://gerrit.ovirt.org/11853 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8958d7a6ba7b48f2390acab7b300cf4e539a550c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: fix tunneled migration regression ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1176/ (2/3)
-- To view, visit http://gerrit.ovirt.org/11853 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8958d7a6ba7b48f2390acab7b300cf4e539a550c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Peter V. Saveliev has posted comments on this change.
Change subject: vdsm: fix tunneled migration regression ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/11853 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8958d7a6ba7b48f2390acab7b300cf4e539a550c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: fix tunneled migration regression ......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/11853 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8958d7a6ba7b48f2390acab7b300cf4e539a550c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: fix tunneled migration regression ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1176/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1211/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/322/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/11853 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8958d7a6ba7b48f2390acab7b300cf4e539a550c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm: fix tunneled migration regression ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/11853 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8958d7a6ba7b48f2390acab7b300cf4e539a550c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: fix tunneled migration regression ......................................................................
vdsm: fix tunneled migration regression
Change-Id: I8958d7a6ba7b48f2390acab7b300cf4e539a550c Signed-off-by: Peter V. Saveliev peet@redhat.com Signed-off-by: Vinzenz Feenstra vfeenstr@redhat.com --- M vdsm/libvirtvm.py 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: Saggi Mizrahi: Looks good to me, approved Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Peter V. Saveliev: Verified
-- To view, visit http://gerrit.ovirt.org/11853 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I8958d7a6ba7b48f2390acab7b300cf4e539a550c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: fix tunneled migration regression ......................................................................
Patch Set 1:
oh goodness, I have sinned.
-- To view, visit http://gerrit.ovirt.org/11853 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8958d7a6ba7b48f2390acab7b300cf4e539a550c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org
-
Dan Kenigsberg -
Jenkins CI RO -
peet＠redhat.com -
smizrahi＠redhat.com -
Vinzenz Feenstra