From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: pylint: storageServer: ExampleConnection: improve documented interface
......................................................................
pylint: storageServer: ExampleConnection: improve documented interface
ExampleConnection serves as a "documentation class". This patch fixes
the signature of its __eq__ and __ne__ methods.
Signed-off-by Dan Kenigsberg <danken(a)redhat.com>
Change-Id: I2dd21331439a5fcb911c8e86be2aa78fc0c12b21
---
M vdsm/storage/storageServer.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/69337/1
diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py
index a40767f..dc3fd80 100644
--- a/vdsm/storage/storageServer.py
+++ b/vdsm/storage/storageServer.py
@@ -89,12 +89,12 @@
Don't use this to monitor connection health"""
pass
- def __eq__(self):
+ def __eq__(self, other):
"""Implement this! It will be used to detect multiple connections
to
the same target"""
pass
- def __ne__(self):
+ def __ne__(self, other):
"""Must be implemented otherwise != operator will return True for
equal
objects"""
--
To view, visit
https://gerrit.ovirt.org/69337
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2dd21331439a5fcb911c8e86be2aa78fc0c12b21
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>