Federico Simoncelli has uploaded a new change for review.
Change subject: Adding more qemuImg commands ......................................................................
Adding more qemuImg commands
Change-Id: I1fbe822da8544ece4fcce9cb5b15a39a9bb35a64 --- M vdsm/qemuImg.py 1 file changed, 48 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/2612/1 -- To view, visit http://gerrit.ovirt.org/2612 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I1fbe822da8544ece4fcce9cb5b15a39a9bb35a64 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Adding more qemuImg commands ......................................................................
Patch Set 1: I would prefer that you didn't submit this
We have similar things in volume.py . Can you please look at it?
-- To view, visit http://gerrit.ovirt.org/2612 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1fbe822da8544ece4fcce9cb5b15a39a9bb35a64 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Adding more qemuImg commands ......................................................................
Patch Set 1:
We have similar things in volume.py . Can you please look at it?
Yes I did saw them, a following patch is going to replace those calls with these wrappers.
-- To view, visit http://gerrit.ovirt.org/2612 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1fbe822da8544ece4fcce9cb5b15a39a9bb35a64 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Adding more qemuImg commands ......................................................................
Patch Set 2: I would prefer that you didn't submit this
I think you need rebase it now on top of http://gerrit.ovirt.org/#change,2611
-- To view, visit http://gerrit.ovirt.org/2612 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1fbe822da8544ece4fcce9cb5b15a39a9bb35a64 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding more qemuImg commands ......................................................................
Patch Set 2: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/65/
-- To view, visit http://gerrit.ovirt.org/2612 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1fbe822da8544ece4fcce9cb5b15a39a9bb35a64 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding more qemuImg commands ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/65/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/2612 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1fbe822da8544ece4fcce9cb5b15a39a9bb35a64 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Federico Simoncelli has abandoned this change.
Change subject: Adding more qemuImg commands ......................................................................
Abandoned
These changes were slowly introduced by other patches.
vdsm-patches@lists.fedorahosted.org
-
Federico Simoncelli -
Igor Lvovsky -
Jenkins CI RO