From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: logUtils: Move logUtils module to vdsm.common
......................................................................
logUtils: Move logUtils module to vdsm.common
logUtils has been relocated to common, to make it clearer
that it is being used by multiple subsystems, and verifying that it
has no dependencies on non-common vdsm code.
The module has been renamed to logutils.
This patch also fixes lib/vdsm/common/api.py which depended on an
external (non common) module.
A follow up patch is planned to add traceback to this module.
In order to support upgrades of systems that have manually edited the
logger conf file, a small proxy is left in the current logUtils module,
pointing to the new location under common.
Change-Id: Ic642205e3d5515acfeb607bb5dcad24f699d286f
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/api/vdsmapi.py
M lib/vdsm/common/api.py
A lib/vdsm/common/logutils.py
M lib/vdsm/logUtils.py
M lib/vdsm/storage/misc.py
M lib/vdsm/storage/resourceManager.py
M lib/vdsm/storage/task.py
M lib/vdsm/throttledlog.py
M lib/yajsonrpc/__init__.py
M static/etc/vdsm/logger.conf.in
M static/etc/vdsm/svdsm.logger.conf.in
M tests/Makefile.am
R tests/common/logutils_test.py
M vdsm/API.py
M vdsm/storage/image.py
M vdsm/virt/vm.py
16 files changed, 301 insertions(+), 269 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit
https://gerrit.ovirt.org/76919
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic642205e3d5515acfeb607bb5dcad24f699d286f
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>