Yaniv Bronhaim has uploaded a new change for review.
Change subject: Changing persisted value to libvirt logrotate configure ......................................................................
Changing persisted value to libvirt logrotate configure
Setting persisted to false means that is-configured won't check the status of this file. This to avoid differences between ovirt-3.4 configuration to ovirt-3.5 in /etc/logrotate.d/libvirtd
In ovirt-3.4 we set the prefix of the configuration without the conf version, therefore in 3.5 we alerted that libvirt is not configured and asked to run vdsm-tool configure all-over again without having any differences between the versions.
Change-Id: I3f1c4d5d513e8699543727fff9f30a8213c66bfd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1168695 Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com --- M lib/vdsm/tool/configurators/libvirt.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/35758/1
diff --git a/lib/vdsm/tool/configurators/libvirt.py b/lib/vdsm/tool/configurators/libvirt.py index 796bc9e..35ae5d4 100644 --- a/lib/vdsm/tool/configurators/libvirt.py +++ b/lib/vdsm/tool/configurators/libvirt.py @@ -482,7 +482,7 @@ 'configure': _prefixAndPrepend, 'prependFile': 'LRCONF_EXAMPLE', 'removeConf': _unprefixAndRemoveSection, - 'persisted': True, + 'persisted': False, },
'LRCONF_EXAMPLE': {
Yaniv Bronhaim has posted comments on this change.
Change subject: Changing persisted value to libvirt logrotate configure ......................................................................
Patch Set 1: Verified+1
Alon Bar-Lev has posted comments on this change.
Change subject: Changing persisted value to libvirt logrotate configure ......................................................................
Patch Set 1:
not sure I follow... but we do want to make sure this file is intact and valid, no?
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Changing persisted value to libvirt logrotate configure ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13812/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13023/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13975/ : ABORTED
Dan Kenigsberg has posted comments on this change.
Change subject: Changing persisted value to libvirt logrotate configure ......................................................................
Patch Set 1: Code-Review+2
Smells like a horrible hack.
But since we plan to drop the libvirt.logrotate section anyway, we can leave with it.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Changing persisted value to libvirt logrotate configure ......................................................................
Changing persisted value to libvirt logrotate configure
Setting persisted to false means that is-configured won't check the status of this file. This to avoid differences between ovirt-3.4 configuration to ovirt-3.5 in /etc/logrotate.d/libvirtd
In ovirt-3.4 we set the prefix of the configuration without the conf version, therefore in 3.5 we alerted that libvirt is not configured and asked to run vdsm-tool configure all-over again without having any differences between the versions.
Change-Id: I3f1c4d5d513e8699543727fff9f30a8213c66bfd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1168695 Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-on: http://gerrit.ovirt.org/35758 Reviewed-by: Dan Kenigsberg danken@redhat.com --- M lib/vdsm/tool/configurators/libvirt.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Changing persisted value to libvirt logrotate configure ......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_merg... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/258/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-fc20-x86_64_mer... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/475/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el7-x86_64_merg... : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/273/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4267/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/280/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/282/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-fc21-x86_64_mer... : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6105/ : SUCCESS
vdsm-patches@lists.fedorahosted.org