Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/23947
to review the following change.
Change subject: sos: plugin should ignore /var/run/vdsm/storage
......................................................................
sos: plugin should ignore /var/run/vdsm/storage
In case sos plugin includes /var/run/vdsm/storage and it contains
symlinks to block devices it can make the host fill the disk
and eventually create a 0 sized sosreport.
Change-Id: Ie60d681cc744f2407a0ddf9406225e73497ac648
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reviewed-on:
http://gerrit.ovirt.org/23925
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/sos/vdsm.py.in
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/23947/1
diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index 2f50e75..6bc111a 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -121,5 +121,6 @@
import glob
for f in glob.glob("@VDSMRUNDIR@/*"):
- if not f.endswith('.vfd') and not
f.endswith('/isoUploader'):
+ if not f.endswith('.vfd') and not f.endswith('/isoUploader')
\
+ and not f.endswith('/storage'):
self.addCopySpec(f)
--
To view, visit
http://gerrit.ovirt.org/23947
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie60d681cc744f2407a0ddf9406225e73497ac648
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>