From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: use vdsm.common.constants
......................................................................
Patch Set 11:
no idea how the failure is related to the patch
ERROR: test_multiple_vlans (network.tc_test.TestConfigureOutbound)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
return func(*args, **keywargs)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/tests/network/tc_test.py",
line 456, in test_multiple_vlans
self.device_name, v.tag)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/network/configurators/qos.py",
line 48, in configure_outbound
qosOutbound)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/network/configurators/qos.py",
line 163, in _qdisc_conf_out
if not _is_explicit_defined_default_class(dev):
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/network/configurators/qos.py",
line 208, in _is_explicit_defined_default_class
netinfo = NetInfo(cache_get())
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/network/netinfo/cache.py",
line 140, in get
return _get(vdsmnets)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/network/netinfo/cache.py",
line 66, in _get
devices_info = _devices_report(ipaddrs, routes)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/network/netinfo/cache.py",
line 111, in _devices_report
devinfo = devs_report['bondings'][dev.name] = bonding.info(dev)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/network/netinfo/bonding.py",
line 77, in info
bond = Bond(link.name)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/network/link/bond/sysfs_driver.py",
line 40, in __init__
super(BondSysFS, self).__init__(name, slaves, options)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/network/link/bond/__init__.py",
line 41, in __init__
self._import_existing()
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/network/link/bond/sysfs_driver.py",
line 129, in _import_existing
self._options = sysfs_options.get_options(self._properties)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/network/link/bond/sysfs_options.py",
line 142, in get_options
opts_keys = _filter_out_default_opts(bond_properties, opts_keys)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/network/link/bond/sysfs_options.py",
line 149, in _filter_out_default_opts
defaults = getDefaultBondingOptions(mode)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/common/cache.py",
line 41, in __call__
value = self.func(*args)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/network/link/bond/sysfs_options.py",
line 212, in getDefaultBondingOptions
defaults = getAllDefaultBondingOptions()
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/common/cache.py",
line 41, in __call__
value = self.func(*args)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/lib/vdsm/network/link/bond/sysfs_options.py",
line 226, in getAllDefaultBondingOptions
with open(BONDING_DEFAULTS) as defaults:
IOError: [Errno 2] No such file or directory:
'/usr/share/vdsm/bonding-defaults.json'
--
To view, visit
https://gerrit.ovirt.org/79437
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8571a806f09195007622d15eff59e72b55042559
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No