Saggi Mizrahi has uploaded a new change for review.
Change subject: stomp: Make sure the \0 is read before slicing the buffer ......................................................................
stomp: Make sure the \0 is read before slicing the buffer
In python if you try and slice past the end of the list\string you get an empty string and not an IndexError
The original code check that we got all the data and sliced past the ending \0. But on rare cases where the message ended exactly with all the content but the \0 was not received.
The slicing code would silently ignore the fact that the index doesn't exist and would return an empty string and switch the parser state making all future data have the wrong offset.
This in turn made the command '\0SEND' instead of 'SEND' which has no handler and where silently ignored. The only way to solve this was to reconnect.
Bug-Url: http://bugzilla.redhat.com/1169100 Change-Id: Ie0d8eaae161f3ec6c77726f4f9da044ab7c629d4 Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M lib/yajsonrpc/stomp.py 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/35938/1
diff --git a/lib/yajsonrpc/stomp.py b/lib/yajsonrpc/stomp.py index 04c23ba..d99ed98 100644 --- a/lib/yajsonrpc/stomp.py +++ b/lib/yajsonrpc/stomp.py @@ -247,9 +247,12 @@ buf = self._get_buffer() cl = self._contentLength ndata = len(buf) - if ndata < cl: + if ndata < (cl + 1): return False
+ if buf[cl] != "\0": + raise RuntimeError("Frame end is missing \0") + remainingBytes = 0 self._flush() body = buf
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13950/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13161/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14114/ : FAILURE
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer ......................................................................
Patch Set 1: Code-Review+1
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer ......................................................................
Patch Set 1: Code-Review-1
this was merged apart of http://gerrit.ovirt.org/#/c/36806/
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer ......................................................................
Patch Set 2:
* Update tracker::#1169100::OK * Check Bug-Url::OK * Check Public Bug::#1169100::OK, public bug * Check Product::#1169100::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer ......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15984/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15183/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16154/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/960/ : FAILURE
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer ......................................................................
Patch Set 2: Code-Review-1
this one should be already fixed. is this rebased?
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer ......................................................................
Patch Set 3:
* Update tracker::#1169100::OK * Check Bug-Url::OK * Check Public Bug::#1169100::OK, public bug * Check Product::#1169100::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer ......................................................................
Patch Set 4:
* Update tracker::#1169100::OK * Check Bug-Url::OK * Check Public Bug::#1169100::OK, public bug * Check Product::#1169100::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer ......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16344/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15544/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16514/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer ......................................................................
Patch Set 5:
* Update tracker::#1169100::OK * Check Bug-Url::OK * Check Public Bug::#1169100::OK, public bug * Check Product::#1169100::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer ......................................................................
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16452/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16623/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15652/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer ......................................................................
Patch Set 5: Code-Review-1
see Yaniv's comment in v1
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer ......................................................................
Patch Set 5:
Thank you for bringing this up. This patch as it is was used as base for https://gerrit.ovirt.org/#/c/36806/ but there are more changes in this patch I will make sure that we differentiate both.
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 6:
* Update tracker::#1169100::OK * Check Bug-Url::OK * Check Public Bug::#1169100::OK, public bug * Check Product::#1169100::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 6: Verified+1
Verified by running engine 3.5, host installing vdsm and checking the logs for potential issues.
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 7:
* Update tracker::#1169100::OK * Check Bug-Url::OK * Check Public Bug::#1169100::OK, public bug * Check Product::#1169100::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16656/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16827/ : FAILURE
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 7: Code-Review-1
im quite sure you can abandon it
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 7:
I sill would like to keep. During development I have seen it being thrown so let's use it as sanity check.
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 8:
* Update tracker::#1169100::OK * Check Bug-Url::OK * Check Public Bug::#1169100::OK, public bug * Check Product::#1169100::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 8: Verified+1
I would like to keep this patch as sanity check since I have seen it useful during development. Rebased and verified with engine 3.5.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16756/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16928/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 9:
* Update tracker::#1169100::OK * Check Bug-Url::OK * Check Public Bug::#1169100::OK, public bug * Check Product::#1169100::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16787/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16959/ : FAILURE
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 9: Code-Review+1
its different patch - https://gerrit.ovirt.org/#/c/37018/2/lib/yajsonrpc/stomp.py
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 10:
* Update tracker::#1169100::OK * Check Bug-Url::OK * Check Public Bug::#1169100::OK, public bug * Check Product::#1169100::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16864/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17036/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 11:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16954/
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 11:
* Update tracker::#1169100::OK * Check Bug-Url::OK * Check Public Bug::#1169100::OK, public bug * Check Product::#1169100::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 11:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17127/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16954/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17127/ : FAILURE
Dima Kuznetsov has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 11: Code-Review+1
Yeela Kaplan has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 11: Code-Review+1
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 12:
* Update tracker::#1169100::OK * Check Bug-Url::OK * Check Public Bug::#1169100::OK, public bug * Check Product::#1169100::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 12:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17575/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 12:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17749/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17575/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17749/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/35938/12/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py:
Line 252: ndata = len(buf) Line 253: if ndata < (cl + 1): Line 254: return False Line 255: Line 256: if buf[cl] != "\0": It is possible that reported content length is greater than buffer size (E.g. maliciously crafted frame - just guessing) thus this code explodes with IndexError?
if buf is string (str object), maybe you can use endswith().
If you like this latter case, we must be careful with python3 future compatibility, however. Line 257: raise RuntimeError("Frame end is missing \0") Line 258: Line 259: remainingBytes = 0 Line 260: self._flush()
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/35938/12/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py:
Line 252: ndata = len(buf) Line 253: if ndata < (cl + 1): Line 254: return False Line 255: Line 256: if buf[cl] != "\0":
It is possible that reported content length is greater than buffer size (E.
Content length value was delivered in frame header from the other side. This value do not contain frame end character (like in stomp spec). There is rare situation when whole frame was part of current buffer content but '\0' is not in the buffer and it will be read as part of next recv.
This fix makes sure that we do not have such situation. Line 257: raise RuntimeError("Frame end is missing \0") Line 258: Line 259: remainingBytes = 0 Line 260: self._flush()
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 13:
* Update tracker::#1169100::OK * Check Bug-Url::OK * Check Public Bug::#1169100::OK, public bug * Check Product::#1169100::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 13:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17788/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 13:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17614/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17614/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17788/ : SUCCESS
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 14:
* Update tracker::#1169100::OK * Check Bug-Url::OK * Check Public Bug::#1169100::OK, public bug * Check Product::#1169100::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 14:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17776/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 14:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17947/
Francesco Romani has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/35938/12/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py:
Line 252: ndata = len(buf) Line 253: if ndata < (cl + 1): Line 254: return False Line 255: Line 256: if buf[cl] != "\0":
Content length value was delivered in frame header from the other side. Thi
ok Line 257: raise RuntimeError("Frame end is missing \0") Line 258: Line 259: remainingBytes = 0 Line 260: self._flush()
Francesco Romani has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/35938/14/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py:
Line 252: ndata = len(buf) Line 253: if ndata < (cl + 1): Line 254: return False Line 255: Line 256: if buf[cl] != "\0": why not buf.endswith("\0") ? Line 257: raise RuntimeError("Frame end is missing \0") Line 258: Line 259: remainingBytes = 0 Line 260: self._flush()
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/35938/14/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py:
Line 252: ndata = len(buf) Line 253: if ndata < (cl + 1): Line 254: return False Line 255: Line 256: if buf[cl] != "\0":
why not buf.endswith("\0") ?
We could use endswith as well. Will update. Line 257: raise RuntimeError("Frame end is missing \0") Line 258: Line 259: remainingBytes = 0 Line 260: self._flush()
Francesco Romani has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/35938/14/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py:
Line 252: ndata = len(buf) Line 253: if ndata < (cl + 1): Line 254: return False Line 255: Line 256: if buf[cl] != "\0":
We could use endswith as well. Will update.
It is not terribly important, but could be clearer _and_ faster. Your call, mine was a question, not a request. Line 257: raise RuntimeError("Frame end is missing \0") Line 258: Line 259: remainingBytes = 0 Line 260: self._flush()
Dan Kenigsberg has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 14: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
stomp: Make sure the \0 is a last char in the buffer
We need to provide sanity check to be sure that buffer contains \0 as last character.
Bug-Url: http://bugzilla.redhat.com/1169100 Change-Id: Ie0d8eaae161f3ec6c77726f4f9da044ab7c629d4 Signed-off-by: Saggi Mizrahi smizrahi@redhat.com Signed-off-by: pkliczewski piotr.kliczewski@gmail.com Reviewed-on: https://gerrit.ovirt.org/35938 Reviewed-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-by: Dima Kuznetsov dkuznets@redhat.com Reviewed-by: Yeela Kaplan ykaplan@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M lib/yajsonrpc/stomp.py 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: Piotr Kliczewski: Verified Yeela Kaplan: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Dima Kuznetsov: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 15:
* Update tracker::#1169100::OK * Set MODIFIED::bug 1169100::::#1169100::::IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 15:
Build Started (1/12) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4872/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 15:
Build Started (2/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_mer...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 15:
Build Started (3/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_mer...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 15:
Build Started (4/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/900/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 15:
Build Started (5/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/896/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 15:
Build Started (6/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_me...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 15:
Build Started (7/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/898/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 15:
Build Started (8/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_me...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 15:
Build Started (9/12) -> http://jenkins.ovirt.org/job/sshnaidm_vdsm_master_create-rpms-fc21-ppc64_mer...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 15:
Build Started (10/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/40/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 15:
Build Started (11/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_me...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 15:
Build Started (12/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/863/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/896/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_me... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4872/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/863/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_mer... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/900/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_me... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/898/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_mer... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_me... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/40/ : SUCCESS
http://jenkins.ovirt.org/job/sshnaidm_vdsm_master_create-rpms-fc21-ppc64_mer... : SUCCESS
vdsm-patches@lists.fedorahosted.org