Dan Kenigsberg has uploaded a new change for review.
Change subject: confNet: report missing net params as ERR_BAD_PARAMS ......................................................................
confNet: report missing net params as ERR_BAD_PARAMS
Change-Id: I6e6b48332f27d1b976a8cd8069d252133ff32378 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/configNetwork.py 1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/6959/1 -- To view, visit http://gerrit.ovirt.org/6959 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I6e6b48332f27d1b976a8cd8069d252133ff32378 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: confNet: report missing net params as ERR_BAD_PARAMS ......................................................................
Patch Set 1: I would prefer that you didn't submit this
looks like over-complex solution for minor test case
-- To view, visit http://gerrit.ovirt.org/6959 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6e6b48332f27d1b976a8cd8069d252133ff32378 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: confNet: report missing net params as ERR_BAD_PARAMS ......................................................................
Patch Set 1: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/246/
-- To view, visit http://gerrit.ovirt.org/6959 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6e6b48332f27d1b976a8cd8069d252133ff32378 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: confNet: report missing net params as ERR_BAD_PARAMS ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/246/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6959 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6e6b48332f27d1b976a8cd8069d252133ff32378 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has abandoned this change.
Change subject: confNet: report missing net params as ERR_BAD_PARAMS ......................................................................
Patch Set 1: Abandoned
-- To view, visit http://gerrit.ovirt.org/6959 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I6e6b48332f27d1b976a8cd8069d252133ff32378 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org