Change in vdsm[master]: After fail to connect to supervdsm more than 3 time restart ...

List overview All Threads
Download

newer

older

Change in vdsm[master]: sos:...

Change in vdsm[master]: vdsm:...

ybronhei＠redhat.com

11 Feb 2013 11 Feb '13

4:30 p.m.

Yaniv Bronhaim has uploaded a new change for review.

Change subject: After fail to connect to supervdsm more than 3 time restart the process ......................................................................

After fail to connect to supervdsm more than 3 time restart the process

When connect is failed more than 3 times it might be that multiprocessing couldn't create the socket file. Killing the process and try again will create the socket properly

Change-Id: Iafe112893a76686edd2949d4f40b734646fd74df Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=910005 Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com --- M vdsm/supervdsm.py 1 file changed, 5 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/11932/1

diff --git a/vdsm/supervdsm.py b/vdsm/supervdsm.py index 10abae0..65ad06b 100644 --- a/vdsm/supervdsm.py +++ b/vdsm/supervdsm.py @@ -194,7 +194,11 @@ def launch(self): self._firstLaunch = False self._start() - utils.retry(self._connect, Exception, timeout=60) + try: + utils.retry(self._connect, Exception, timeout=60, tries=3) + except: + self.kill() + self.launch()

def __getattr__(self, name): return ProxyCaller(self, name)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: Iafe112893a76686edd2949d4f40b734646fd74df Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com

Show replies by date

Jenkins CI RO

11 Feb 11 Feb

4:30 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time restart the process ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/348/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:30 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time restart the process ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1237/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:30 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time restart the process ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1202/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:34 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time restart the process ......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1202/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1237/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/348/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Iafe112893a76686edd2949d4f40b734646fd74df Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

ybronhei＠redhat.com

4:43 p.m.

Yaniv Bronhaim has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time restart the process ......................................................................

Patch Set 1: Verified

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

smizrahi＠redhat.com

7 p.m.

Saggi Mizrahi has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time restart the process ......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

.................................................... File vdsm/supervdsm.py Line 194: def launch(self): Line 195: self._firstLaunch = False Line 196: self._start() Line 197: try: Line 198: utils.retry(self._connect, Exception, timeout=60, tries=3) No reason to retry at all. Kill if launch fails. The user should be responsible for retries Line 199: except: Line 200: self.kill() Line 201: self.launch() Line 202:

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

smizrahi＠redhat.com

7:13 p.m.

Saggi Mizrahi has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time restart the process ......................................................................

Patch Set 1: Looks good to me, but someone else must approve

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

8:24 p.m.

Dan Kenigsberg has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time restart the process ......................................................................

Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

once upon at time we had

def _restartSupervdsm(self): self._killSupervdsm() self._launchSupervdsm()

but you convinced me that we should not do such things during startup. what has changed?

.................................................... File vdsm/supervdsm.py Line 195: self._firstLaunch = False Line 196: self._start() Line 197: try: Line 198: utils.retry(self._connect, Exception, timeout=60, tries=3) Line 199: except: you should not swallow exception without logging and a good excuse. Line 200: self.kill() Line 201: self.launch() Line 202: Line 203: def __getattr__(self, name):

Line 197: try: Line 198: utils.retry(self._connect, Exception, timeout=60, tries=3) Line 199: except: Line 200: self.kill() Line 201: self.launch() do you really want this recursion without an end condition? it sounds dangerous. Line 202: Line 203: def __getattr__(self, name): Line 204: return ProxyCaller(self, name) Line 205:

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

ybronhei＠redhat.com

12 Feb 12 Feb

7:15 a.m.

Yaniv Bronhaim has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time restart the process ......................................................................

Patch Set 1: (1 inline comment)

we still have kill and launch .. but not in a function :) i didn't imagine that the socket can get deleted or not being created when we start a process by manager object.. so if we can't connect we have to restart.

.................................................... File vdsm/supervdsm.py Line 197: try: Line 198: utils.retry(self._connect, Exception, timeout=60, tries=3) Line 199: except: Line 200: self.kill() Line 201: self.launch() its that or getting into panic and let respawn to take care of it. what do we prefer? Line 202: Line 203: def __getattr__(self, name): Line 204: return ProxyCaller(self, name) Line 205:

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:42 a.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/352/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Iafe112893a76686edd2949d4f40b734646fd74df Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

10:42 a.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1206/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:42 a.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1241/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

10:46 a.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1206/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1241/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/352/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

11:03 a.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/353/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Iafe112893a76686edd2949d4f40b734646fd74df Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

11:03 a.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1242/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

11:03 a.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1207/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

11:06 a.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1207/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1242/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/353/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

11:09 a.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/354/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Iafe112893a76686edd2949d4f40b734646fd74df Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

11:09 a.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1243/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

11:09 a.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1208/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

11:12 a.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1208/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1243/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/354/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:52 p.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/365/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Iafe112893a76686edd2949d4f40b734646fd74df Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

5:52 p.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1219/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

5:52 p.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1254/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

bazulay＠redhat.com

5:59 p.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

Barak Azulay has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 5:

Please update the comment and explain the race

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

6:19 p.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 5:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1219/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1254/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/365/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7:02 p.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1256/ (3/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Iafe112893a76686edd2949d4f40b734646fd74df Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

7:02 p.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/367/ (2/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7:02 p.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1221/ (1/3)

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

ybronhei＠redhat.com

7:04 p.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

Yaniv Bronhaim has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 6: Verified

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

smizrahi＠redhat.com

7:25 p.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

Saggi Mizrahi has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 6: Looks good to me, but someone else must approve

If my patch doesn't get in first

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7:39 p.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

oVirt Jenkins CI Server has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 6:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1221/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1256/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/367/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

13 Feb 13 Feb

9:01 a.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

Dan Kenigsberg has posted comments on this change.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

Patch Set 6: Looks good to me, approved

I suppose we have to take it in - until we have a normal flow of supervdsm spawning vdsm which communicates to its parent via pipe.

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

9:11 a.m.

New subject: Change in vdsm[master]: After fail to connect to supervdsm more than 3 time vdsm get...

Dan Kenigsberg has submitted this change and it was merged.

Change subject: After fail to connect to supervdsm more than 3 time vdsm gets into panic ......................................................................

After fail to connect to supervdsm more than 3 time vdsm gets into panic

Due to race between old supervdsm instance to the new instance after prepareForShutdown, sometimes the socket is removed after new supervdsm started to listen on it. _pokeParent thread unlink the socket when distinguish that vdsm is dead. This can take more time than the time that takes to vdsm to startup and start the new instance of supervdsm. The unlink removes the socket file and vdsm cannot communicate with supervdsm. When the communication fails, vdsm calls panic and restart itself, this will start supervdsm again as needed.

Approvals: Yaniv Bronhaim: Verified Saggi Mizrahi: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: Iafe112893a76686edd2949d4f40b734646fd74df Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

4157

Age (days ago)

4159

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

34 comments

5 participants

tags (0)

participants (5)

bazulay＠redhat.com
Dan Kenigsberg
Jenkins CI RO
smizrahi＠redhat.com
ybronhei＠redhat.com