Ido Barkan has uploaded a new change for review.
Change subject: fixed TestConfigNetwork.testAddNetworkValidation ......................................................................
fixed TestConfigNetwork.testAddNetworkValidation
Change-Id: Ieebd1c90577c37c3245d09936b44e1bc2fab520d Signed-off-by: ibarkan ibarkan@redhat.com --- M tests/configNetworkTests.py 1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/35777/1
diff --git a/tests/configNetworkTests.py b/tests/configNetworkTests.py index 5241f91..46d11bb 100644 --- a/tests/configNetworkTests.py +++ b/tests/configNetworkTests.py @@ -25,7 +25,8 @@ from testlib import VdsmTestCase as TestCaseBase from monkeypatch import MonkeyPatch
-from network import api, configurators +from network import api +from network.configurators import ifcfg from network import errors from network.models import Bond, Bridge, Nic, Vlan
@@ -51,9 +52,9 @@ @MonkeyPatch(netinfo, 'networks', _fakeNetworks) @MonkeyPatch(netinfo, 'getMaxMtu', lambda *x: 1500) @MonkeyPatch(netinfo, 'getMtu', lambda *x: 1500) - @MonkeyPatch(configurators.ifcfg, 'ifdown', lambda *x: + @MonkeyPatch(ifcfg, 'ifdown', lambda *x: _raiseInvalidOpException()) - @MonkeyPatch(configurators.ifcfg, 'ifup', + @MonkeyPatch(ifcfg, 'ifup', lambda *x: _raiseInvalidOpException()) @MonkeyPatch(Bond, 'configure', lambda *x: _raiseInvalidOpException()) @MonkeyPatch(Bridge, 'configure', lambda *x: _raiseInvalidOpException())
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fixed TestConfigNetwork.testAddNetworkValidation ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13832/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13043/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13995/ : FAILURE
Ondřej Svoboda has posted comments on this change.
Change subject: fixed TestConfigNetwork.testAddNetworkValidation ......................................................................
Patch Set 1:
Dan, do you remember an almost _identical_ patch of mine?
I had the same problem in the past. http://gerrit.ovirt.org/#/c/31108/1/tests/configNetworkTests.py
Ido, is it this one? AttributeError: 'module' object has no attribute 'ifcfg'
Ido Barkan has abandoned this change.
Change subject: fixed TestConfigNetwork.testAddNetworkValidation ......................................................................
Abandoned
I still do not understand why this is happening but removing vdsm from the system completely before building it solves this.
a working workaround:
sudo yum erase -y `rpm -qa | grep vdsm | perl -pe 's|-[0-9].*||' | paste -sd " "`
this suggests that the problem somehow relates to unclean system due to repeating vdsm installation while vdsm project structure is changing, and failing to properly remove packages before moving them around.
vdsm-patches@lists.fedorahosted.org