Saggi Mizrahi has uploaded a new change for review.
Change subject: stomp: Remove redundant code ......................................................................
stomp: Remove redundant code
Change-Id: I7b9fb4b4b4c5286733f8f4435ec6dcea04f96233 Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M lib/yajsonrpc/stomp.py 1 file changed, 4 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/35939/1
diff --git a/lib/yajsonrpc/stomp.py b/lib/yajsonrpc/stomp.py index d99ed98..279aa24 100644 --- a/lib/yajsonrpc/stomp.py +++ b/lib/yajsonrpc/stomp.py @@ -253,15 +253,12 @@ if buf[cl] != "\0": raise RuntimeError("Frame end is missing \0")
- remainingBytes = 0 self._flush() - body = buf - self._write_buffer(body[cl + 1:]) - body = body[:cl] + self._write_buffer(buf[cl + 1:]) + body = buf[:cl]
- if remainingBytes == 0: - self._tmpFrame.body = body - self._pushFrame() + self._tmpFrame.body = body + self._pushFrame()
return True
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13952/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13163/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14116/ : FAILURE
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 1:
seems right
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15986/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15185/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16156/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/962/ : FAILURE
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 2: Code-Review+1
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16345/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15545/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16515/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16454/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16625/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15654/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 5:
seems ok at glance, but test(s) will help gaining confidence
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 5:
Will explore possibility of adding tests.
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 6: Verified+1
Verified by running engine 3.5, host installing vdsm and checking the logs for potential issues.
Francesco Romani has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 6: Code-Review+1
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16658/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16829/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16759/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16931/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16789/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16961/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16866/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17038/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 11:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16957/
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 11:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17130/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16957/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17130/ : FAILURE
Dima Kuznetsov has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 11: Code-Review+1
Yeela Kaplan has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 11: Code-Review+1
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 12:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17578/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 12:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17752/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17578/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17752/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 13:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17617/
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 13:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17791/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17617/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17791/ : SUCCESS
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 14:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17779/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 14:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17950/
Dan Kenigsberg has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 14: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: stomp: Remove redundant code ......................................................................
stomp: Remove redundant code
Change-Id: I7b9fb4b4b4c5286733f8f4435ec6dcea04f96233 Signed-off-by: Saggi Mizrahi smizrahi@redhat.com Reviewed-on: https://gerrit.ovirt.org/35939 Reviewed-by: Yaniv Bronhaim ybronhei@redhat.com Tested-by: Piotr Kliczewski piotr.kliczewski@gmail.com Reviewed-by: Francesco Romani fromani@redhat.com Reviewed-by: Dima Kuznetsov dkuznets@redhat.com Reviewed-by: Yeela Kaplan ykaplan@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M lib/yajsonrpc/stomp.py 1 file changed, 4 insertions(+), 7 deletions(-)
Approvals: Piotr Kliczewski: Verified Yeela Kaplan: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Dima Kuznetsov: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve
automation@ovirt.org has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 15:
Build Started (1/12) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4873/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 15:
Build Started (2/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_mer...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 15:
Build Started (3/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_mer...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 15:
Build Started (4/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/901/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 15:
Build Started (5/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_me...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 15:
Build Started (6/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/897/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 15:
Build Started (7/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/899/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 15:
Build Started (8/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_me...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 15:
Build Started (9/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/41/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 15:
Build Started (10/12) -> http://jenkins.ovirt.org/job/sshnaidm_vdsm_master_create-rpms-fc21-ppc64_mer...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 15:
Build Started (11/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_me...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 15:
Build Started (12/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/864/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Remove redundant code ......................................................................
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/897/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_me... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4873/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/864/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_mer... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/901/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_me... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/899/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_mer... : FAILURE
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_me... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/41/ : SUCCESS
http://jenkins.ovirt.org/job/sshnaidm_vdsm_master_create-rpms-fc21-ppc64_mer... : SUCCESS
vdsm-patches@lists.fedorahosted.org
-
automation＠ovirt.org -
Dan Kenigsberg -
dkuznets＠redhat.com -
fromani＠redhat.com -
Jenkins CI RO -
Piotr Kliczewski -
smizrahi＠redhat.com -
ybronhei＠redhat.com -
ykaplan＠redhat.com